starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #3894] [MERGED] Fixes #2921: Replace tags filter with Select2 widget #12685

New Issue
Closed
opened 2025-12-29 22:23:02 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:23:02 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3894
Author: @hSaria
Created: 1/11/2020
Status: ✅ Merged
Merged: 2/4/2020
Merged by: @jeremystretch

Base: develop ← Head: 2921-tags-select2

📝 Commits (10+)

📊 Changes

29 files changed (+59 additions, -47 deletions)

View changed files

📝 docs/release-notes/version-2.7.md (+4 -0)
📝 netbox/circuits/forms.py (+4 -2)
📝 netbox/dcim/forms.py (+17 -1)
📝 netbox/ipam/forms.py (+7 -1)
📝 netbox/secrets/forms.py (+2 -1)
📝 netbox/templates/circuits/circuit_list.html (+0 -1)
📝 netbox/templates/circuits/provider_list.html (+0 -1)
📝 netbox/templates/dcim/device_component_list.html (+0 -1)
📝 netbox/templates/dcim/device_list.html (+0 -1)
📝 netbox/templates/dcim/devicetype_list.html (+0 -1)
📝 netbox/templates/dcim/powerfeed_list.html (+0 -1)
📝 netbox/templates/dcim/rack_list.html (+0 -1)
📝 netbox/templates/dcim/site_list.html (+0 -1)
📝 netbox/templates/dcim/virtualchassis_list.html (+0 -1)
➖ netbox/templates/inc/tags_panel.html (+0 -13)
📝 netbox/templates/ipam/aggregate_list.html (+0 -1)
📝 netbox/templates/ipam/ipaddress_list.html (+0 -1)
📝 netbox/templates/ipam/prefix_list.html (+0 -1)
📝 netbox/templates/ipam/service_list.html (+0 -1)
📝 netbox/templates/ipam/vlan_list.html (+0 -1)

...and 9 more files

📄 Description

Fixes: #2921

Replaces the tags form with a Select2 widget inside of the search form.

Bonus: You no longer need to manually include the inc/tags_panel.html in the list view templates; the field will automatically get thrown to the bottom of the search form if the model supports tags. The inventory items list is a case in point.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3894 **Author:** [@hSaria](https://github.com/hSaria) **Created:** 1/11/2020 **Status:** ✅ Merged **Merged:** 2/4/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `2921-tags-select2` --- ### 📝 Commits (10+) - [`834fd40`](https://github.com/netbox-community/netbox/commit/834fd408bdde93d1600ae3c73f466b732465bcd5) Fixes #2921: Replace tags filter with Select2 widget - [`a8d9fe7`](https://github.com/netbox-community/netbox/commit/a8d9fe799b819c2866c3868078a92ae51340b210) Removed tags filter field from view - [`2f28dec`](https://github.com/netbox-community/netbox/commit/2f28dec891ed83066dc7c7bd707af1d3ea770713) Tag filter field for filter forms - [`865e3e7`](https://github.com/netbox-community/netbox/commit/865e3e7c9f20dab7a994c662c7a210def5ad2c9e) Updated changelog - [`83ee831`](https://github.com/netbox-community/netbox/commit/83ee83142a03679cd7274ee0627092c7f665f24a) Merge branch 'develop' into 2921-tags-select2 - [`e10333b`](https://github.com/netbox-community/netbox/commit/e10333bf2bc90465cee4e00cef6ad8c9ce032949) Fetch choices during form initialization - [`a7e87ee`](https://github.com/netbox-community/netbox/commit/a7e87eeadc1d80d8aeaa31562f51b17075681f6b) Merge branch 'develop' into 2921-tags-select2 - [`2949bfa`](https://github.com/netbox-community/netbox/commit/2949bfaaa7ba88959f16e57f4eb252551b6fcebb) Merge branch 'develop' into 2921-tags-select2 - [`8f91e9b`](https://github.com/netbox-community/netbox/commit/8f91e9b079b52121b5bf7617560faa8c7cdca773) Added #2921 changelog - [`2c0f321`](https://github.com/netbox-community/netbox/commit/2c0f3214569e8f99fd19a8195edd7a12c2993956) Merge branch '2921-tags-select2' of https://github.com/hSaria/netbox into 2921-tags-select2 ### 📊 Changes **29 files changed** (+59 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `docs/release-notes/version-2.7.md` (+4 -0) 📝 `netbox/circuits/forms.py` (+4 -2) 📝 `netbox/dcim/forms.py` (+17 -1) 📝 `netbox/ipam/forms.py` (+7 -1) 📝 `netbox/secrets/forms.py` (+2 -1) 📝 `netbox/templates/circuits/circuit_list.html` (+0 -1) 📝 `netbox/templates/circuits/provider_list.html` (+0 -1) 📝 `netbox/templates/dcim/device_component_list.html` (+0 -1) 📝 `netbox/templates/dcim/device_list.html` (+0 -1) 📝 `netbox/templates/dcim/devicetype_list.html` (+0 -1) 📝 `netbox/templates/dcim/powerfeed_list.html` (+0 -1) 📝 `netbox/templates/dcim/rack_list.html` (+0 -1) 📝 `netbox/templates/dcim/site_list.html` (+0 -1) 📝 `netbox/templates/dcim/virtualchassis_list.html` (+0 -1) ➖ `netbox/templates/inc/tags_panel.html` (+0 -13) 📝 `netbox/templates/ipam/aggregate_list.html` (+0 -1) 📝 `netbox/templates/ipam/ipaddress_list.html` (+0 -1) 📝 `netbox/templates/ipam/prefix_list.html` (+0 -1) 📝 `netbox/templates/ipam/service_list.html` (+0 -1) 📝 `netbox/templates/ipam/vlan_list.html` (+0 -1) _...and 9 more files_ </details> ### 📄 Description ### Fixes: #2921 Replaces the tags form with a Select2 widget inside of the search form. Bonus: You no longer need to manually include the `inc/tags_panel.html` in the list view templates; the field will automatically get thrown to the bottom of the search form if the model supports tags. The inventory items list is a case in point. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:23:02 +01:00
adam closed this issue 2025-12-29 22:23:02 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12685
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?