starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-02-26 02:35:12 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #3881] [MERGED] Fixes #3729: Standardize FilterSet names #12677

New Issue
Closed
opened 2025-12-29 22:23:00 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:23:00 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3881
Author: @jeremystretch
Created: 1/10/2020
Status: ✅ Merged
Merged: 1/10/2020
Merged by: @jeremystretch

Base: develop-2.7 ← Head: 3729-filterset-naming

📝 Commits (10+)

  • 847cf9d Renamed circuits FilterSets
  • 0767de2 Renamed dcim FilterSets
  • 97654b7 Renamed extras FilterSets
  • 83c0d1e Renamed ipam FilterSets
  • 15e1f62 Renamed secrets FilterSets
  • a77fadd Renamed tenancy FilterSets
  • 49a6a36 Renamed virtualization FilterSets
  • da0ac4f Rename filter variables for utility views
  • e3807a8 Update filterset naming for global search view
  • 528b345 Move TenancyFilterSet to filters.py

📊 Changes

31 files changed (+458 additions, -457 deletions)

View changed files

📝 netbox/circuits/api/views.py (+4 -4)
📝 netbox/circuits/filters.py (+9 -9)
📝 netbox/circuits/tests/test_filters.py (+4 -4)
📝 netbox/circuits/views.py (+8 -8)
📝 netbox/dcim/api/views.py (+35 -35)
📝 netbox/dcim/filters.py (+72 -72)
📝 netbox/dcim/tests/test_filters.py (+36 -36)
📝 netbox/dcim/views.py (+71 -71)
📝 netbox/extras/api/views.py (+5 -5)
📝 netbox/extras/filters.py (+12 -12)
📝 netbox/extras/tests/test_filters.py (+3 -3)
📝 netbox/extras/views.py (+7 -7)
📝 netbox/ipam/api/views.py (+9 -9)
📝 netbox/ipam/filters.py (+19 -19)
📝 netbox/ipam/tests/test_filters.py (+9 -9)
📝 netbox/ipam/views.py (+30 -30)
📝 netbox/netbox/views.py (+28 -28)
📝 netbox/secrets/api/views.py (+2 -2)
📝 netbox/secrets/filters.py (+4 -4)
📝 netbox/secrets/tests/test_filters.py (+2 -2)

...and 11 more files

📄 Description

Fixes: #3729

Finally fix FilterSet class naming to distinguish between FilterSets and individual Filters (e.g. ProviderFilter becomes ProviderFilterSet).

Merges into develop-2.7 to avoid causing too much confusion.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3881 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 1/10/2020 **Status:** ✅ Merged **Merged:** 1/10/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop-2.7` ← **Head:** `3729-filterset-naming` --- ### 📝 Commits (10+) - [`847cf9d`](https://github.com/netbox-community/netbox/commit/847cf9d0387d049015f688865d6c83cc46153888) Renamed circuits FilterSets - [`0767de2`](https://github.com/netbox-community/netbox/commit/0767de205e05ee6efca990862abc634232fd9066) Renamed dcim FilterSets - [`97654b7`](https://github.com/netbox-community/netbox/commit/97654b7585a13d9fab81123bbbd24a9087e35e98) Renamed extras FilterSets - [`83c0d1e`](https://github.com/netbox-community/netbox/commit/83c0d1ef44d3d482d997f61d2ce136d5e8a35c71) Renamed ipam FilterSets - [`15e1f62`](https://github.com/netbox-community/netbox/commit/15e1f62919c66f14b18a0e22a93562c0cd13ac44) Renamed secrets FilterSets - [`a77fadd`](https://github.com/netbox-community/netbox/commit/a77fadd114fa2c949c09cecd5dd05738a4d5d872) Renamed tenancy FilterSets - [`49a6a36`](https://github.com/netbox-community/netbox/commit/49a6a36f4cc3d7149c39d3c1a9fd7da019719e76) Renamed virtualization FilterSets - [`da0ac4f`](https://github.com/netbox-community/netbox/commit/da0ac4ff1ed31e1366161bfa0dfa89e22b31f767) Rename filter variables for utility views - [`e3807a8`](https://github.com/netbox-community/netbox/commit/e3807a89372d816561928a5969e43e8268514984) Update filterset naming for global search view - [`528b345`](https://github.com/netbox-community/netbox/commit/528b345f57b2ca21e920030f8d067fbf3a8785ec) Move TenancyFilterSet to filters.py ### 📊 Changes **31 files changed** (+458 additions, -457 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/api/views.py` (+4 -4) 📝 `netbox/circuits/filters.py` (+9 -9) 📝 `netbox/circuits/tests/test_filters.py` (+4 -4) 📝 `netbox/circuits/views.py` (+8 -8) 📝 `netbox/dcim/api/views.py` (+35 -35) 📝 `netbox/dcim/filters.py` (+72 -72) 📝 `netbox/dcim/tests/test_filters.py` (+36 -36) 📝 `netbox/dcim/views.py` (+71 -71) 📝 `netbox/extras/api/views.py` (+5 -5) 📝 `netbox/extras/filters.py` (+12 -12) 📝 `netbox/extras/tests/test_filters.py` (+3 -3) 📝 `netbox/extras/views.py` (+7 -7) 📝 `netbox/ipam/api/views.py` (+9 -9) 📝 `netbox/ipam/filters.py` (+19 -19) 📝 `netbox/ipam/tests/test_filters.py` (+9 -9) 📝 `netbox/ipam/views.py` (+30 -30) 📝 `netbox/netbox/views.py` (+28 -28) 📝 `netbox/secrets/api/views.py` (+2 -2) 📝 `netbox/secrets/filters.py` (+4 -4) 📝 `netbox/secrets/tests/test_filters.py` (+2 -2) _...and 11 more files_ </details> ### 📄 Description ### Fixes: #3729 Finally fix FilterSet class naming to distinguish between FilterSets and individual Filters (e.g. `ProviderFilter` becomes `ProviderFilterSet`). Merges into `develop-2.7` to avoid causing too much confusion. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:23:00 +01:00
adam closed this issue 2025-12-29 22:23:00 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12677
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?