starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #3816] [MERGED] Fixes #3815: Select2 width handling via theme #12650

New Issue
Closed
opened 2025-12-29 22:22:51 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:22:51 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3816
Author: @hSaria
Created: 1/1/2020
Status: ✅ Merged
Merged: 1/2/2020
Merged by: @jeremystretch

Base: develop ← Head: 3815-select2-width

📝 Commits (2)

  • 57ea73d Turn off Select2 static width calculation
  • cfa078c Added theme to select2 of tags

📊 Changes

1 file changed (+7 additions, -3 deletions)

View changed files

📝 netbox/project-static/js/forms.js (+7 -3)

📄 Description

Fixes: #3815

Turn off the static width by Select2 as the bootstrap theme is handling it; Select2 is setting it just a touch too small.

The tag's select2 didn't have the theme so had to add it. Alternatively, I could leave the width as is for the tag and remove the theme (as it was), though I don't know if it was missing for a reason.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3816 **Author:** [@hSaria](https://github.com/hSaria) **Created:** 1/1/2020 **Status:** ✅ Merged **Merged:** 1/2/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `3815-select2-width` --- ### 📝 Commits (2) - [`57ea73d`](https://github.com/netbox-community/netbox/commit/57ea73db469b64543ee4691c85cfb98bb051493b) Turn off Select2 static width calculation - [`cfa078c`](https://github.com/netbox-community/netbox/commit/cfa078c9291a06830025f984a79e96430cbee0fd) Added theme to select2 of tags ### 📊 Changes **1 file changed** (+7 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/project-static/js/forms.js` (+7 -3) </details> ### 📄 Description ### Fixes: #3815 Turn off the static width by Select2 as the bootstrap theme is handling it; Select2 is setting it just a touch too small. The tag's `select2` didn't have the theme so had to add it. Alternatively, I could leave the width as is for the tag and remove the theme (as it was), though I don't know if it was missing for a reason. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:22:51 +01:00
adam closed this issue 2025-12-29 22:22:51 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12650
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?