starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #3814] [MERGED] Fixes #3589: Interface VLAN filtering #12646

New Issue
Closed
opened 2025-12-29 22:22:50 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:22:50 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3814
Author: @hSaria
Created: 1/1/2020
Status: ✅ Merged
Merged: 1/6/2020
Merged by: @jeremystretch

Base: develop ← Head: 3589-interface-tagged-vlans

📝 Commits (10+)

  • 05570ae Clean tagged VLANs
  • aa4f73f Removed trailing space
  • a110b0b Removed no-longer-used choices (now handled via API-based select)
  • d267aeb Filter VLANs to only those in the current site or global
  • 1a57120 3589 changelog
  • 7ad9e8a More informative error message
  • d3c6caf Limit tagged validation to tagged interfaces
  • fa55571 Merge remote-tracking branch 'netbox-community/develop' into 3589-interface-tagged-vlans
  • c45daca Removed changes that will be covered in #3840
  • 7dddd47 Updated changelog

📊 Changes

2 files changed (+15 additions, -90 deletions)

View changed files

📝 docs/release-notes/version-2.6.md (+4 -0)
📝 netbox/dcim/forms.py (+11 -90)

📄 Description

Fixes: #3589

  • Perform validation on the tagged VLANs similar to that which is already performed on the untagged VLAN
  • Removes the legacy choices filter that is no longer used because the API-based select widgets override the choices
  • Limit the select filter to only global VLANs or VLANs in the same site as the device

Because there currently isn't a way to specify multiple values for the same parameter, I had to work around it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3814 **Author:** [@hSaria](https://github.com/hSaria) **Created:** 1/1/2020 **Status:** ✅ Merged **Merged:** 1/6/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `3589-interface-tagged-vlans` --- ### 📝 Commits (10+) - [`05570ae`](https://github.com/netbox-community/netbox/commit/05570ae4ade98eca869a07767f932af23d06e3a6) Clean tagged VLANs - [`aa4f73f`](https://github.com/netbox-community/netbox/commit/aa4f73ffbfa3c23a5d64595753f18a32fc672dfd) Removed trailing space - [`a110b0b`](https://github.com/netbox-community/netbox/commit/a110b0badbd8370e06ce8c0edfb1d82640a6bebe) Removed no-longer-used choices (now handled via API-based select) - [`d267aeb`](https://github.com/netbox-community/netbox/commit/d267aeb62112015db2f4b1cdf90afda348bfd700) Filter VLANs to only those in the current site or global - [`1a57120`](https://github.com/netbox-community/netbox/commit/1a57120b789435b1bc27139e0563bfe7a984794a) 3589 changelog - [`7ad9e8a`](https://github.com/netbox-community/netbox/commit/7ad9e8a2fbd5e655143a7a40d2d4b41765dd1f4d) More informative error message - [`d3c6caf`](https://github.com/netbox-community/netbox/commit/d3c6caf8a8db5cc643f0f5ed7fab2c78dff97c28) Limit tagged validation to tagged interfaces - [`fa55571`](https://github.com/netbox-community/netbox/commit/fa5557150392ef56a7eeea61c9827140b900ff11) Merge remote-tracking branch 'netbox-community/develop' into 3589-interface-tagged-vlans - [`c45daca`](https://github.com/netbox-community/netbox/commit/c45daca5f2376ce5b061b232f6c3a80b40aa6a0e) Removed changes that will be covered in #3840 - [`7dddd47`](https://github.com/netbox-community/netbox/commit/7dddd4734ce5225aad0bcf1fecbf7d9c7aff1d70) Updated changelog ### 📊 Changes **2 files changed** (+15 additions, -90 deletions) <details> <summary>View changed files</summary> 📝 `docs/release-notes/version-2.6.md` (+4 -0) 📝 `netbox/dcim/forms.py` (+11 -90) </details> ### 📄 Description ### Fixes: #3589 * Perform validation on the tagged VLANs similar to that which is already performed on the untagged VLAN * Removes the legacy choices filter that is no longer used because the API-based select widgets override the choices * Limit the select filter to only global VLANs or VLANs in the same site as the device > Because there currently isn't a way to specify multiple values for the same parameter, I had to work around it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:22:50 +01:00
adam closed this issue 2025-12-29 22:22:50 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12646
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?