[PR #3802] [MERGED] Fixes 3762 #12641

Closed
opened 2025-12-29 22:22:48 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3802
Author: @hSaria
Created: 12/29/2019
Status: Merged
Merged: 12/30/2019
Merged by: @jeremystretch

Base: developHead: 3762-datetime-selectors


📝 Commits (6)

  • 6dea8dd Flatpickr library statics
  • 4c2e2e0 Include Flatpickr library globally
  • aa4588f Load flatpickr using selectors (classes)
  • 7399aa0 Add datetime widgets
  • 51b0fe4 Changelog for 3762
  • b5177c6 Merge branch 'develop' into 3762-datetime-selectors

📊 Changes

11 files changed (+1653 additions, -20 deletions)

View changed files

📝 docs/release-notes/version-2.6.md (+2 -1)
📝 netbox/circuits/forms.py (+2 -3)
📝 netbox/extras/forms.py (+5 -9)
📝 netbox/ipam/forms.py (+7 -4)
netbox/project-static/flatpickr-4.6.3/flatpickr.min.js (+2 -0)
netbox/project-static/flatpickr-4.6.3/themes/dark.css (+784 -0)
netbox/project-static/flatpickr-4.6.3/themes/light.css (+798 -0)
📝 netbox/project-static/js/forms.js (+18 -0)
📝 netbox/templates/_base.html (+2 -0)
📝 netbox/users/forms.py (+3 -3)
📝 netbox/utilities/forms.py (+30 -0)

📄 Description

Fixes: #3762

Added a datetime picker to the following fields:

  • Circuits: Circuit's install_date
  • Extras: Custom fields (CF_TYPE_DATE), changelog filter form (time_before, time_after)
  • IPAM: Aggregate's date_added (edit and bulk edit)
  • Users: Token's expires

Let me know if I missed something.

I've included the dark theme to assist with any work related to #3599, though it is inactive (not being referenced in the _base.html template); the light theme is currently being used.

image image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3802 **Author:** [@hSaria](https://github.com/hSaria) **Created:** 12/29/2019 **Status:** ✅ Merged **Merged:** 12/30/2019 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `3762-datetime-selectors` --- ### 📝 Commits (6) - [`6dea8dd`](https://github.com/netbox-community/netbox/commit/6dea8ddbce907a0de8c81c20fc4002cc858a36f0) Flatpickr library statics - [`4c2e2e0`](https://github.com/netbox-community/netbox/commit/4c2e2e0fa35d62aa2b2e87f115307aec3865344f) Include Flatpickr library globally - [`aa4588f`](https://github.com/netbox-community/netbox/commit/aa4588f9ba115d856fa54530cbcfefd89850b393) Load flatpickr using selectors (classes) - [`7399aa0`](https://github.com/netbox-community/netbox/commit/7399aa0c5e7e4c5bb216535840dee84c81d38400) Add datetime widgets - [`51b0fe4`](https://github.com/netbox-community/netbox/commit/51b0fe459662564d2d091692eb98a29c454f7a3b) Changelog for 3762 - [`b5177c6`](https://github.com/netbox-community/netbox/commit/b5177c608d5fc2f3a3e8a81e4c71c0f50fd5c775) Merge branch 'develop' into 3762-datetime-selectors ### 📊 Changes **11 files changed** (+1653 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `docs/release-notes/version-2.6.md` (+2 -1) 📝 `netbox/circuits/forms.py` (+2 -3) 📝 `netbox/extras/forms.py` (+5 -9) 📝 `netbox/ipam/forms.py` (+7 -4) ➕ `netbox/project-static/flatpickr-4.6.3/flatpickr.min.js` (+2 -0) ➕ `netbox/project-static/flatpickr-4.6.3/themes/dark.css` (+784 -0) ➕ `netbox/project-static/flatpickr-4.6.3/themes/light.css` (+798 -0) 📝 `netbox/project-static/js/forms.js` (+18 -0) 📝 `netbox/templates/_base.html` (+2 -0) 📝 `netbox/users/forms.py` (+3 -3) 📝 `netbox/utilities/forms.py` (+30 -0) </details> ### 📄 Description ### Fixes: #3762 Added a datetime picker to the following fields: * Circuits: Circuit's `install_date` * Extras: Custom fields (`CF_TYPE_DATE`), changelog filter form (`time_before`, `time_after`) * IPAM: Aggregate's `date_added` (edit and bulk edit) * Users: Token's `expires` Let me know if I missed something. I've included the dark theme to assist with any work related to #3599, though it is inactive (not being referenced in the `_base.html` template); the light theme is currently being used. <img width="326" alt="image" src="https://user-images.githubusercontent.com/34197532/71554758-8b6ecf00-2a1b-11ea-9668-5356ffd2485d.png"> <img width="327" alt="image" src="https://user-images.githubusercontent.com/34197532/71554764-a17c8f80-2a1b-11ea-8fde-f8f0b4f9f543.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:22:48 +01:00
adam closed this issue 2025-12-29 22:22:49 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12641