starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #3690] [CLOSED] Switch from "pycryptodome" to "pycryptodomex" #12616

New Issue
Closed
opened 2025-12-29 22:22:40 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:22:40 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3690
Author: @knobix
Created: 11/13/2019
Status: ❌ Closed

Base: develop ← Head: switch-from-pycryptodome-to-pycryptodomex-3689

📝 Commits (1)

  • 5c55945 Switch from "pycryptodome" to "pycryptodomex"

📊 Changes

7 files changed (+10 additions, -9 deletions)

View changed files

📝 base_requirements.txt (+1 -1)
📝 netbox/secrets/api/views.py (+1 -1)
📝 netbox/secrets/forms.py (+2 -2)
📝 netbox/secrets/models.py (+3 -3)
📝 netbox/secrets/tests/test_models.py (+1 -1)
📝 old_requirements.txt (+1 -0)
📝 requirements.txt (+1 -1)

📄 Description

Fixes: #3689

When NetBox is used outside an virtualenv it can happen that there's a
Python package conflict between "pycryptodome", which is required by
NetBox, and "pycrypto", which some other package requires.

Thus switch from "pycryptodome" to its library independent variant
"pycryptodomex". The latter one uses "Cryptodome" as package name
instead of "Crypto".

My tests were so far:

  • Login/Logoff -> OK
  • Unlock/Lock secrets via private key -> OK
  • Create new user key pair -> OK
  • Activate new user key pair -> OK
  • Unlock/Lock secrets with new user key pair -> OK

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3690 **Author:** [@knobix](https://github.com/knobix) **Created:** 11/13/2019 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `switch-from-pycryptodome-to-pycryptodomex-3689` --- ### 📝 Commits (1) - [`5c55945`](https://github.com/netbox-community/netbox/commit/5c5594520ec9fb441df33f747a98ad68b9949a73) Switch from "pycryptodome" to "pycryptodomex" ### 📊 Changes **7 files changed** (+10 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `base_requirements.txt` (+1 -1) 📝 `netbox/secrets/api/views.py` (+1 -1) 📝 `netbox/secrets/forms.py` (+2 -2) 📝 `netbox/secrets/models.py` (+3 -3) 📝 `netbox/secrets/tests/test_models.py` (+1 -1) 📝 `old_requirements.txt` (+1 -0) 📝 `requirements.txt` (+1 -1) </details> ### 📄 Description ### Fixes: #3689 When NetBox is used outside an virtualenv it can happen that there's a Python package conflict between "pycryptodome", which is required by NetBox, and "pycrypto", which some other package requires. Thus switch from "pycryptodome" to its library independent variant "pycryptodomex". The latter one uses "Cryptodome" as package name instead of "Crypto". My tests were so far: - Login/Logoff -> OK - Unlock/Lock secrets via private key -> OK - Create new user key pair -> OK - Activate new user key pair -> OK - Unlock/Lock secrets with new user key pair -> OK --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:22:40 +01:00
adam closed this issue 2025-12-29 22:22:40 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12616
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?