starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #3667] [MERGED] Hide password change page when user is logged in using LDAP #12613

New Issue
Closed
opened 2025-12-29 22:22:38 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:22:38 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3667
Author: @steffann
Created: 11/3/2019
Status: ✅ Merged
Merged: 11/6/2019
Merged by: @jeremystretch

Base: develop ← Head: 3139-disable-user-password-change-if-come-in-with-ldap-auth

📝 Commits (1)

  • 7f779e3 Hide password change page when user is logged in using LDAP

📊 Changes

2 files changed (+9 additions, -3 deletions)

View changed files

📝 netbox/templates/users/_user.html (+5 -3)
📝 netbox/users/views.py (+4 -0)

📄 Description

Fixes: #3139

  • Hide the change-password menu item when the user has ldap_username set
  • The menu item is hidden, but in case the user ends up on the change-password page: eedirect from the change-password page to the profile page when the user has ldap_username set

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3667 **Author:** [@steffann](https://github.com/steffann) **Created:** 11/3/2019 **Status:** ✅ Merged **Merged:** 11/6/2019 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `3139-disable-user-password-change-if-come-in-with-ldap-auth` --- ### 📝 Commits (1) - [`7f779e3`](https://github.com/netbox-community/netbox/commit/7f779e39426eb3c24dda9684c1b1e2859ec4fac0) Hide password change page when user is logged in using LDAP ### 📊 Changes **2 files changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/templates/users/_user.html` (+5 -3) 📝 `netbox/users/views.py` (+4 -0) </details> ### 📄 Description ### Fixes: #3139 - Hide the change-password menu item when the user has ldap_username set - The menu item is hidden, but in case the user ends up on the change-password page: eedirect from the change-password page to the profile page when the user has ldap_username set --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:22:38 +01:00
adam closed this issue 2025-12-29 22:22:39 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12613
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?