Hide unused custom fields #1261

New Issue

adam · 2025-12-29T16:30:53+01:00

adam commented

2025-12-29 16:30:53 +01:00

Originally created by @Bill-Irvine on GitHub (Sep 25, 2017).

Issue type

[-] Feature request
[ ] Bug report
[ ] Documentation

Environment

Python version: 2.7
NetBox version: 2.1.4

Description

We have around 20 different types of circuits being stored in our database each with differing fields that require being filled out, i.e Dark Fibre links have completely separate details and fields to a Lit fibre circuit.

This leaves a large amount of blank space on the view of a completed circuit when accounting for the various types of circuits and their own custom fields.

One way of approaching this would be to allow separate custom fields per circuit type, but that seems like a much larger change that would require far more complexity, planning and modification.

The other much simpler option would be to have all fields accessible at circuit creation (and editing) and simply hide the ones that aren't in use.

Let me know your thoughts.

Originally created by @Bill-Irvine on GitHub (Sep 25, 2017).  ### Issue type [-] Feature request  [ ] Bug report  [ ] Documentation   ### Environment * Python version: 2.7 * NetBox version: 2.1.4  ### Description We have around 20 different types of circuits being stored in our database each with differing fields that require being filled out, i.e Dark Fibre links have completely separate details and fields to a Lit fibre circuit. This leaves a large amount of blank space on the view of a completed circuit when accounting for the various types of circuits and their own custom fields. One way of approaching this would be to allow separate custom fields per circuit type, but that seems like a much larger change that would require far more complexity, planning and modification. The other much simpler option would be to have all fields accessible at circuit creation (and editing) and simply hide the ones that aren't in use. Let me know your thoughts.

adam closed this issue

2025-12-29 16:30:53 +01:00

adam commented

2025-12-29 16:30:53 +01:00

@jeremystretch commented on GitHub (Sep 25, 2017):

Custom fields are meant to offer a minor convenience in tracking small amounts of esoteric data. If you've got twenty custom fields defined for a single type of object, I'd argue that you're better off using a separate application to store this data. Custom fields are already quite complex, and their abstract nature would exponentially increase that complexity if we tried to add the ability to limit the display of fields based on other object fields. Sorry, but I have to reject this if only for the sake of my own sanity.

@jeremystretch commented on GitHub (Sep 25, 2017): Custom fields are meant to offer a minor convenience in tracking small amounts of esoteric data. If you've got twenty custom fields defined for a single type of object, I'd argue that you're better off using a separate application to store this data. Custom fields are already quite complex, and their abstract nature would exponentially increase that complexity if we tried to add the ability to limit the display of fields based on other object fields. Sorry, but I have to reject this if only for the sake of my own sanity.

adam commented

2025-12-29 16:30:53 +01:00

@Bill-Irvine commented on GitHub (Sep 27, 2017):

Completely understand Jeremy, i know custom fields are a touchy subject :)

Just a note as i'm unsure if i got across what i intended. The idea was to simply change the html template of the custom fields panel to not display a custom field if its empty, not tie this to any particular circuit type.

The below works for me and is what i'm currently using if anybody else is interested.

custom_fields_panel.html

{% for field, value in custom_fields.items %}
	**{% if value is not None  %}**
                <tr>
                    <td>{{ field }}</td>
                    <td>
                        {% if field.type == 300 and value == True %}
                            <i class="glyphicon glyphicon-ok text-success" title="True"></i>
                        {% elif field.type == 300 and value == False %}
                            <i class="glyphicon glyphicon-remove text-danger" title="False"></i>
                        {% elif field.type == 500 and value %}
                            <a href="{{ value }}">{{ value|truncatechars:70 }}</a>
                        {% elif field.type == 200 or value %}
                            {{ value }}
                        {% elif field.required %}
                            <span class="text-warning">Not defined</span>
                        {% else %}
                            <span class="text-muted">N/A</span>
                        {% endif %}
                    </td>
                </tr>
	**{% endif %}**
{% endfor %}

@Bill-Irvine commented on GitHub (Sep 27, 2017): Completely understand Jeremy, i know custom fields are a touchy subject :) Just a note as i'm unsure if i got across what i intended. The idea was to simply change the html template of the custom fields panel to not display a custom field if its empty, not tie this to any particular circuit type. The below works for me and is what i'm currently using if anybody else is interested. custom_fields_panel.html ``` {% for field, value in custom_fields.items %} **{% if value is not None %}** <tr> <td>{{ field }}</td> <td> {% if field.type == 300 and value == True %} {% elif field.type == 300 and value == False %} {% elif field.type == 500 and value %} <a href="{{ value }}">{{ value|truncatechars:70 }}</a> {% elif field.type == 200 or value %} {{ value }} {% elif field.required %} Not defined {% else %} N/A {% endif %} </td> </tr> **{% endif %}** {% endfor %} ```

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#1261