[PR #3553] [MERGED] Replace all instances of .extra() in QuerySets with annotations #3117 #12579

New Issue

adam · 2025-12-29T22:22:26+01:00

adam commented

2025-12-29 22:22:26 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3553
Author: @chambersh1129
Created: 9/29/2019
Status: ✅ Merged
Merged: 10/10/2019
Merged by: @kobayashi

Base: develop ← Head: develop

📝 Commits (2)

bdb3838 Replace all instances of .extra() in QuerySets with annotations, including references in docstrings
52e9369 PEP 8 E121 continuation line under-indented for hanging indent fix

📊 Changes

3 files changed (+12 additions, -10 deletions)

View changed files

📝 netbox/ipam/querysets.py (+1 -1)
📝 netbox/ipam/views.py (+5 -4)
📝 netbox/utilities/managers.py (+6 -5)

📄 Description

Fixes: #3117

replaced two instances of queryset.extra() function with queryset.annotate()
replaced single reference of .extra() in docstrings to .annotate() in order to prevent confusion if function is refactored in the future

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3553 **Author:** [@chambersh1129](https://github.com/chambersh1129) **Created:** 9/29/2019 **Status:** ✅ Merged **Merged:** 10/10/2019 **Merged by:** [@kobayashi](https://github.com/kobayashi) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (2) - [`bdb3838`](https://github.com/netbox-community/netbox/commit/bdb3838d71606cb28d83b82dc5323641788ea4ad) Replace all instances of .extra() in QuerySets with annotations, including references in docstrings - [`52e9369`](https://github.com/netbox-community/netbox/commit/52e9369af4a485087522acee52ae95005739bae7) PEP 8 E121 continuation line under-indented for hanging indent fix ### 📊 Changes **3 files changed** (+12 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/querysets.py` (+1 -1) 📝 `netbox/ipam/views.py` (+5 -4) 📝 `netbox/utilities/managers.py` (+6 -5) </details> ### 📄 Description **Fixes**: #3117 - replaced two instances of queryset.extra() function with queryset.annotate() - replaced single reference of .extra() in docstrings to .annotate() in order to prevent confusion if function is refactored in the future --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 22:22:26 +01:00

adam closed this issue

2025-12-29 22:22:26 +01:00

adam referenced this issue

2025-12-29 23:22:27 +01:00

[PR #13007] [MERGED] Fix #12579 create cable and add another error #14093

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#12579