[PR #3536] [MERGED] Fixes: #3464 - Change color picker to dynamic coloring from static CSS #12575

Closed
opened 2025-12-29 22:22:25 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3536
Author: @DanSheps
Created: 9/24/2019
Status: Merged
Merged: 9/24/2019
Merged by: @jeremystretch

Base: developHead: develop


📝 Commits (1)

  • 17ec9aa Fixes: #3464 - Change color picker to dynamic coloring from static CSS

📊 Changes

3 files changed (+4 additions, -116 deletions)

View changed files

📝 netbox/project-static/css/base.css (+0 -110)
📝 netbox/project-static/js/forms.js (+2 -5)
📝 netbox/utilities/templates/widgets/colorselect_option.html (+2 -1)

📄 Description

Fixes: #3464

Changes from static CSS to python function to determine fgcolor.

Change summary:

  • Change widget to use function instead of static css classes
  • Remove static css classes
  • Change JS to swap the style on the form

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3536 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 9/24/2019 **Status:** ✅ Merged **Merged:** 9/24/2019 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (1) - [`17ec9aa`](https://github.com/netbox-community/netbox/commit/17ec9aa170fee176209a0dcb327145d9b19a4f20) Fixes: #3464 - Change color picker to dynamic coloring from static CSS ### 📊 Changes **3 files changed** (+4 additions, -116 deletions) <details> <summary>View changed files</summary> 📝 `netbox/project-static/css/base.css` (+0 -110) 📝 `netbox/project-static/js/forms.js` (+2 -5) 📝 `netbox/utilities/templates/widgets/colorselect_option.html` (+2 -1) </details> ### 📄 Description ### Fixes: #3464 Changes from static CSS to python function to determine fgcolor. Change summary: * Change widget to use function instead of static css classes * Remove static css classes * Change JS to swap the style on the form --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:22:25 +01:00
adam closed this issue 2025-12-29 22:22:25 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12575