starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #3350] [MERGED] Add in in-line vlan editing and Bulk vlan editing #12547

New Issue
Closed
opened 2025-12-29 22:22:12 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:22:12 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3350
Author: @DanSheps
Created: 7/17/2019
Status: ✅ Merged
Merged: 9/6/2019
Merged by: @DanSheps

Base: develop ← Head: inline-vlan-editing

📝 Commits (6)

📊 Changes

7 files changed (+155 additions, -157 deletions)

View changed files

📝 netbox/dcim/forms.py (+78 -108)
📝 netbox/dcim/urls.py (+0 -1)
📝 netbox/dcim/views.py (+0 -6)
📝 netbox/project-static/js/forms.js (+64 -9)
📝 netbox/templates/dcim/interface_edit.html (+3 -31)
📝 netbox/utilities/forms.py (+3 -0)
📝 netbox/utilities/views.py (+7 -2)

📄 Description

Fixes:

  • Fixes: #3341 - Add in-line VLAN editing to the edit interface form
  • Fixes: #2160 - Add bulk editing of vlans

Consequential behaviour changes

  • APISelect can now take "full=True" to return a non-brief set
  • Select2 will no group by "group & site, group, site, global" if full=True is set in APISelect
  • BulkEditView checks for QuerySet's and performs getattr().set() instead of setattr() for both regular data and nullified data

In order for this to work, had to check for a queryset being returned during the bulk edit and to use .set() instead of setattr.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3350 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 7/17/2019 **Status:** ✅ Merged **Merged:** 9/6/2019 **Merged by:** [@DanSheps](https://github.com/DanSheps) **Base:** `develop` ← **Head:** `inline-vlan-editing` --- ### 📝 Commits (6) - [`789cb61`](https://github.com/netbox-community/netbox/commit/789cb619f282f7f57c7d8c73138a1c3549d3a092) Fixes #3341 - Added in-line vlan editing - [`b47de47`](https://github.com/netbox-community/netbox/commit/b47de47f33cd4f5ea6fb7fe86afc558f10d52d0a) Resolve problem with pushing to group array - [`1faaced`](https://github.com/netbox-community/netbox/commit/1faacedc475b5f6c481cd2f53f62a3aa5f91f7cf) Hide tagged vlan field when all vlans are tagged. - [`b862dac`](https://github.com/netbox-community/netbox/commit/b862dac57ebb22cd0375169976488fef7ef6b745) Merge branch 'develop' into inline-vlan-editing - [`422b7b1`](https://github.com/netbox-community/netbox/commit/422b7b14b3686161eeac51f6efea13b7c965f7ed) Merge branch 'develop' of https://github.com/netbox-community/netbox into inline-vlan-editing - [`6fc69d5`](https://github.com/netbox-community/netbox/commit/6fc69d5ba65c0b2f37d7b000589ed5f0fb9a48bd) Merge remote-tracking branch 'dansheps/inline-vlan-editing' into inline-vlan-editing ### 📊 Changes **7 files changed** (+155 additions, -157 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms.py` (+78 -108) 📝 `netbox/dcim/urls.py` (+0 -1) 📝 `netbox/dcim/views.py` (+0 -6) 📝 `netbox/project-static/js/forms.js` (+64 -9) 📝 `netbox/templates/dcim/interface_edit.html` (+3 -31) 📝 `netbox/utilities/forms.py` (+3 -0) 📝 `netbox/utilities/views.py` (+7 -2) </details> ### 📄 Description ### Fixes: * Fixes: #3341 - Add in-line VLAN editing to the edit interface form * Fixes: #2160 - Add bulk editing of vlans Consequential behaviour changes * APISelect can now take "full=True" to return a non-brief set * Select2 will no group by "group & site, group, site, global" if full=True is set in APISelect * BulkEditView checks for QuerySet's and performs getattr().set() instead of setattr() for both regular data and nullified data In order for this to work, had to check for a queryset being returned during the bulk edit and to use .set() instead of setattr. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:22:12 +01:00
adam closed this issue 2025-12-29 22:22:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12547
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?