[PR #3284] [MERGED] Fixes Cacheops with a password protected redis #12536

New Issue

adam · 2025-12-29T22:22:08+01:00

adam commented

2025-12-29 22:22:08 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3284
Author: @cimnine
Created: 6/21/2019
Status: ✅ Merged
Merged: 6/21/2019
Merged by: @lampwins

Base: develop ← Head: fix_pwd_protected_redis_cache

📝 Commits (1)

94ca3ab Fixes Cacheops with a password protected redis

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 netbox/netbox/settings.py (+1 -1)

📄 Description

Fixes: #3285

As per the README.rst of django-cacheops, if a password is added to the connection string, it must be in the form redis://:password@host:port/db.
Notice the colon, which was missing from the implementation in settings.py.

Fixes https://github.com/digitalocean/netbox/issues/3285

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3284 **Author:** [@cimnine](https://github.com/cimnine) **Created:** 6/21/2019 **Status:** ✅ Merged **Merged:** 6/21/2019 **Merged by:** [@lampwins](https://github.com/lampwins) **Base:** `develop` ← **Head:** `fix_pwd_protected_redis_cache` --- ### 📝 Commits (1) - [`94ca3ab`](https://github.com/netbox-community/netbox/commit/94ca3abefc682c74be26b51404ee9061bea61dd0) Fixes Cacheops with a password protected redis ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/settings.py` (+1 -1) </details> ### 📄 Description  ### Fixes: #3285 As per the [`README.rst`][1] of `django-cacheops`, if a password is added to the connection string, it must be in the form `redis://:password@host:port/db`. Notice the colon, which was missing from the implementation in [`settings.py`][2]. [1]: https://github.com/Suor/django-cacheops/blob/8ad970d55a3782fbaa027332dcc4ae1ee8c41437/README.rst [2]: https://github.com/digitalocean/netbox/blob/86d5b48007a514e0c7968c9711fed5ede0a78f6c/netbox/netbox/settings.py#L349 Fixes https://github.com/digitalocean/netbox/issues/3285 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 22:22:08 +01:00

adam closed this issue

2025-12-29 22:22:09 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#12536