starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #3219] [CLOSED] Rearrange DCIM models #12524

New Issue
Closed
opened 2025-12-29 22:22:04 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:22:04 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3219
Author: @hellerve
Created: 5/27/2019
Status: ❌ Closed

Base: develop ← Head: fix-3092

📝 Commits (2)

  • aa9a88c dcim: rearrange models, fixing #3092
  • 486149e dcim/models: remove two extra blank lines

📊 Changes

4 files changed (+1143 additions, -1105 deletions)

View changed files

➕ netbox/dcim/models/__init__.py (+3 -0)
➕ netbox/dcim/models/component_models.py (+876 -0)
➕ netbox/dcim/models/component_template_models.py (+258 -0)
📝 netbox/dcim/models/models.py (+6 -1105)

📄 Description

Fixes: #3092

This PR moves from having a models.py in the dcim module to a models module which contains the models, split up into three files (as specified in the description of #3092).

Because modules and files are both importable in the same way, no changes outside of dcim/models are necessary.

Cheers

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3219 **Author:** [@hellerve](https://github.com/hellerve) **Created:** 5/27/2019 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `fix-3092` --- ### 📝 Commits (2) - [`aa9a88c`](https://github.com/netbox-community/netbox/commit/aa9a88c87e21d3bd3ae8ea828328a7914631acf2) dcim: rearrange models, fixing #3092 - [`486149e`](https://github.com/netbox-community/netbox/commit/486149efa1616482045a04409dccf4df2168db6d) dcim/models: remove two extra blank lines ### 📊 Changes **4 files changed** (+1143 additions, -1105 deletions) <details> <summary>View changed files</summary> ➕ `netbox/dcim/models/__init__.py` (+3 -0) ➕ `netbox/dcim/models/component_models.py` (+876 -0) ➕ `netbox/dcim/models/component_template_models.py` (+258 -0) 📝 `netbox/dcim/models/models.py` (+6 -1105) </details> ### 📄 Description ### Fixes: #3092 This PR moves from having a `models.py` in the `dcim` module to a `models` module which contains the models, split up into three files (as specified in the description of #3092). Because modules and files are both importable in the same way, no changes outside of `dcim/models` are necessary. Cheers --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:22:04 +01:00
adam closed this issue 2025-12-29 22:22:04 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12524
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?