starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #3165] [MERGED] Closes #3038: Filtering improvements #12511

New Issue
Closed
opened 2025-12-29 22:22:00 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:22:00 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3165
Author: @jeremystretch
Created: 5/7/2019
Status: ✅ Merged
Merged: 5/9/2019
Merged by: @jeremystretch

Base: develop-2.6 ← Head: 3038-filtering-improvements

📝 Commits (7)

  • 6cb5173 Update query filters to OR multiple values
  • 3d616ba Remove NumericInFilter and id__in filters
  • 205adeb Remove NullableCharFieldFilter; add missing filter fields
  • 8e8c982 Correct Device.position filter
  • ffa34c6 Updated documentation
  • dfffd1e Restore id__in filters to retain backward compatability until v2.7
  • 53b5fed Tweak docs to indicate deprecation of id__in filter

📊 Changes

10 files changed (+191 additions, -68 deletions)

View changed files

📝 CHANGELOG.md (+2 -0)
📝 docs/api/overview.md (+21 -2)
📝 netbox/circuits/filters.py (+3 -3)
📝 netbox/dcim/filters.py (+36 -42)
📝 netbox/ipam/filters.py (+21 -8)
📝 netbox/secrets/filters.py (+2 -2)
📝 netbox/tenancy/filters.py (+2 -2)
📝 netbox/utilities/filters.py (+99 -3)
📝 netbox/virtualization/filters.py (+4 -5)
📝 netbox/virtualization/tests/test_api.py (+1 -1)

📄 Description

Closes: #3038

  • Enable OR query logic when multiple values are passed for a filter
  • Remove the id__in filter from all models (use ?id=1&id=2 format instead)
  • Add miscellaneous missing fields to several models

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3165 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 5/7/2019 **Status:** ✅ Merged **Merged:** 5/9/2019 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop-2.6` ← **Head:** `3038-filtering-improvements` --- ### 📝 Commits (7) - [`6cb5173`](https://github.com/netbox-community/netbox/commit/6cb5173e273a2dfd52e00b51b89adc8985414f50) Update query filters to OR multiple values - [`3d616ba`](https://github.com/netbox-community/netbox/commit/3d616baf754ff96990438d0cc88f836aee7e5232) Remove NumericInFilter and id__in filters - [`205adeb`](https://github.com/netbox-community/netbox/commit/205adeb2e9008e36d8076fb7b4c212f9c2e9faf3) Remove NullableCharFieldFilter; add missing filter fields - [`8e8c982`](https://github.com/netbox-community/netbox/commit/8e8c9822ea42371dea0723aaf635fb1bc5ba4a71) Correct Device.position filter - [`ffa34c6`](https://github.com/netbox-community/netbox/commit/ffa34c61332d0ec5db918e29ccd029a63a9f28d9) Updated documentation - [`dfffd1e`](https://github.com/netbox-community/netbox/commit/dfffd1ea943f8c71b8ad8912110d2e3390e5c6d6) Restore id__in filters to retain backward compatability until v2.7 - [`53b5fed`](https://github.com/netbox-community/netbox/commit/53b5fed8ae5400a3ad5209bf15d63b5a5c793f47) Tweak docs to indicate deprecation of id__in filter ### 📊 Changes **10 files changed** (+191 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+2 -0) 📝 `docs/api/overview.md` (+21 -2) 📝 `netbox/circuits/filters.py` (+3 -3) 📝 `netbox/dcim/filters.py` (+36 -42) 📝 `netbox/ipam/filters.py` (+21 -8) 📝 `netbox/secrets/filters.py` (+2 -2) 📝 `netbox/tenancy/filters.py` (+2 -2) 📝 `netbox/utilities/filters.py` (+99 -3) 📝 `netbox/virtualization/filters.py` (+4 -5) 📝 `netbox/virtualization/tests/test_api.py` (+1 -1) </details> ### 📄 Description ### Closes: #3038 * Enable OR query logic when multiple values are passed for a filter * Remove the `id__in` filter from all models (use `?id=1&id=2` format instead) * Add miscellaneous missing fields to several models --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:22:00 +01:00
adam closed this issue 2025-12-29 22:22:00 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12511
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?