starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #3067] [MERGED] Rename Interface.form_factor to Interface.type #12494

New Issue
Closed
opened 2025-12-29 22:21:54 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:21:54 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3067
Author: @jeremystretch
Created: 4/12/2019
Status: ✅ Merged
Merged: 4/12/2019
Merged by: @jeremystretch

Base: develop-2.6 ← Head: 2920-interface-type

📝 Commits (4)

  • 1a2c9e3 Rename form_factor to type on dcim.Interface
  • 778d56a Update 'form_factor' in docs
  • 4acd842 Maintain backward-compatibile support for Interface.form_factor until v2.7
  • 533520e Rename Interface type (classification) filter to kind

📊 Changes

23 files changed (+616 additions, -552 deletions)

View changed files

📝 CHANGELOG.md (+6 -0)
📝 docs/core-functionality/devices.md (+1 -1)
📝 netbox/dcim/api/serializers.py (+10 -6)
📝 netbox/dcim/api/views.py (+2 -2)
📝 netbox/dcim/constants.py (+127 -127)
📝 netbox/dcim/filters.py (+11 -12)
📝 netbox/dcim/fixtures/dcim.json (+314 -314)
📝 netbox/dcim/forms.py (+18 -18)
📝 netbox/dcim/managers.py (+1 -1)
➕ netbox/dcim/migrations/0073_interface_form_factor_to_type.py (+23 -0)
📝 netbox/dcim/models.py (+56 -24)
📝 netbox/dcim/tables.py (+2 -2)
📝 netbox/dcim/tests/test_api.py (+11 -11)
📝 netbox/dcim/tests/test_models.py (+1 -1)
📝 netbox/dcim/tests/test_views.py (+7 -7)
📝 netbox/templates/dcim/device_lldp_neighbors.html (+1 -1)
📝 netbox/templates/dcim/inc/cable_trace_end.html (+1 -1)
📝 netbox/templates/dcim/inc/interface.html (+2 -2)
📝 netbox/templates/dcim/interface.html (+3 -3)
📝 netbox/templates/dcim/interface_edit.html (+1 -1)

...and 3 more files

📄 Description

Closes: #2920

  • dcim.Interface: form_factor has been renamed to type. Backward-compatibile support for form_factor will be maintained until NetBox v2.7.
  • dcim.Interface: The type filter has been renamed to kind.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3067 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 4/12/2019 **Status:** ✅ Merged **Merged:** 4/12/2019 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop-2.6` ← **Head:** `2920-interface-type` --- ### 📝 Commits (4) - [`1a2c9e3`](https://github.com/netbox-community/netbox/commit/1a2c9e3bba979e2c5c917245a0c68796a2a64135) Rename form_factor to type on dcim.Interface - [`778d56a`](https://github.com/netbox-community/netbox/commit/778d56ac1209b7ed953cd336cf91c356c45e9f22) Update 'form_factor' in docs - [`4acd842`](https://github.com/netbox-community/netbox/commit/4acd84223718733fb65961658f979654c91d295b) Maintain backward-compatibile support for Interface.form_factor until v2.7 - [`533520e`](https://github.com/netbox-community/netbox/commit/533520ec1f30e11352aa4de8d0e3d37887984ae4) Rename Interface type (classification) filter to kind ### 📊 Changes **23 files changed** (+616 additions, -552 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+6 -0) 📝 `docs/core-functionality/devices.md` (+1 -1) 📝 `netbox/dcim/api/serializers.py` (+10 -6) 📝 `netbox/dcim/api/views.py` (+2 -2) 📝 `netbox/dcim/constants.py` (+127 -127) 📝 `netbox/dcim/filters.py` (+11 -12) 📝 `netbox/dcim/fixtures/dcim.json` (+314 -314) 📝 `netbox/dcim/forms.py` (+18 -18) 📝 `netbox/dcim/managers.py` (+1 -1) ➕ `netbox/dcim/migrations/0073_interface_form_factor_to_type.py` (+23 -0) 📝 `netbox/dcim/models.py` (+56 -24) 📝 `netbox/dcim/tables.py` (+2 -2) 📝 `netbox/dcim/tests/test_api.py` (+11 -11) 📝 `netbox/dcim/tests/test_models.py` (+1 -1) 📝 `netbox/dcim/tests/test_views.py` (+7 -7) 📝 `netbox/templates/dcim/device_lldp_neighbors.html` (+1 -1) 📝 `netbox/templates/dcim/inc/cable_trace_end.html` (+1 -1) 📝 `netbox/templates/dcim/inc/interface.html` (+2 -2) 📝 `netbox/templates/dcim/interface.html` (+3 -3) 📝 `netbox/templates/dcim/interface_edit.html` (+1 -1) _...and 3 more files_ </details> ### 📄 Description ## Closes: #2920 * dcim.Interface: `form_factor` has been renamed to `type`. Backward-compatibile support for `form_factor` will be maintained until NetBox v2.7. * dcim.Interface: The `type` filter has been renamed to `kind`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:21:54 +01:00
adam closed this issue 2025-12-29 22:21:54 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12494
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?