starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #3066] [MERGED] Closes #323 #12492

New Issue
Closed
opened 2025-12-29 22:21:53 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:21:53 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3066
Author: @jeremystretch
Created: 4/12/2019
Status: ✅ Merged
Merged: 4/12/2019
Merged by: @jeremystretch

Base: develop-2.6 ← Head: 323-view-permissions

📝 Commits (7)

📊 Changes

42 files changed (+676 additions, -404 deletions)

View changed files

📝 CHANGELOG.md (+23 -0)
📝 docs/configuration/optional-settings.md (+24 -0)
📝 netbox/circuits/tests/test_views.py (+10 -6)
📝 netbox/circuits/views.py (+10 -5)
📝 netbox/dcim/tests/test_views.py (+31 -33)
📝 netbox/dcim/views.py (+65 -34)
📝 netbox/extras/tests/test_views.py (+5 -5)
📝 netbox/extras/views.py (+12 -6)
📝 netbox/ipam/tests/test_views.py (+19 -15)
📝 netbox/ipam/views.py (+39 -19)
📝 netbox/netbox/api.py (+15 -0)
📝 netbox/netbox/configuration.example.py (+8 -0)
📝 netbox/netbox/settings.py (+7 -2)
📝 netbox/secrets/tests/test_views.py (+7 -12)
📝 netbox/secrets/views.py (+7 -6)
📝 netbox/templates/circuits/circuit.html (+5 -3)
📝 netbox/templates/circuits/provider.html (+5 -3)
📝 netbox/templates/dcim/cable.html (+5 -3)
📝 netbox/templates/dcim/device.html (+10 -6)
📝 netbox/templates/dcim/devicetype.html (+5 -3)

...and 22 more files

📄 Description

  • Enforce Django's built-in object type view permissions
  • Implement a custom authentication backend wrapper to allow for exempting individual object types from view permission enforcement via EXEMPT_VIEW_PERMISSIONS configuration setting

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3066 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 4/12/2019 **Status:** ✅ Merged **Merged:** 4/12/2019 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop-2.6` ← **Head:** `323-view-permissions` --- ### 📝 Commits (7) - [`e710ccb`](https://github.com/netbox-community/netbox/commit/e710ccb0e66e7027ffa4174d86c845f086fc9c24) Enforce view permissions for UI views - [`43a569d`](https://github.com/netbox-community/netbox/commit/43a569d18a41907befc0795442034ea3d194d941) Enforce view permissions for API views - [`3e818cd`](https://github.com/netbox-community/netbox/commit/3e818cde694f14b7acb5660f053ce89d137ce09c) Disable navigation links for objects user does not have permission to view - [`df0686a`](https://github.com/netbox-community/netbox/commit/df0686a1bd15ea158c0dc51e535306b1e9fe0de1) Implement custom auth backend and EXEMPT_VIEW_PERMISSIONS setting - [`8c5d544`](https://github.com/netbox-community/netbox/commit/8c5d544734621bcccea0880e97556c4a2aac41da) Changelog for #323 - [`dfa26cc`](https://github.com/netbox-community/netbox/commit/dfa26cc5e284aa690a4ffe0ee5444170573d2cde) Hide non-viewable object types on home page - [`b29944d`](https://github.com/netbox-community/netbox/commit/b29944d5d74cbeca42e057ac631ed87b9ee00b03) Check view permissions for object navigation tabs ### 📊 Changes **42 files changed** (+676 additions, -404 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+23 -0) 📝 `docs/configuration/optional-settings.md` (+24 -0) 📝 `netbox/circuits/tests/test_views.py` (+10 -6) 📝 `netbox/circuits/views.py` (+10 -5) 📝 `netbox/dcim/tests/test_views.py` (+31 -33) 📝 `netbox/dcim/views.py` (+65 -34) 📝 `netbox/extras/tests/test_views.py` (+5 -5) 📝 `netbox/extras/views.py` (+12 -6) 📝 `netbox/ipam/tests/test_views.py` (+19 -15) 📝 `netbox/ipam/views.py` (+39 -19) 📝 `netbox/netbox/api.py` (+15 -0) 📝 `netbox/netbox/configuration.example.py` (+8 -0) 📝 `netbox/netbox/settings.py` (+7 -2) 📝 `netbox/secrets/tests/test_views.py` (+7 -12) 📝 `netbox/secrets/views.py` (+7 -6) 📝 `netbox/templates/circuits/circuit.html` (+5 -3) 📝 `netbox/templates/circuits/provider.html` (+5 -3) 📝 `netbox/templates/dcim/cable.html` (+5 -3) 📝 `netbox/templates/dcim/device.html` (+10 -6) 📝 `netbox/templates/dcim/devicetype.html` (+5 -3) _...and 22 more files_ </details> ### 📄 Description * Enforce Django's built-in object type view permissions * Implement a custom authentication backend wrapper to allow for exempting individual object types from view permission enforcement via `EXEMPT_VIEW_PERMISSIONS` configuration setting --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:21:53 +01:00
adam closed this issue 2025-12-29 22:21:53 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12492
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?