starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #3005] [CLOSED] Set nat_outside as not required in the IPAddressSerializer #12485

New Issue
Closed
opened 2025-12-29 22:21:51 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:21:51 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3005
Author: @dgarros
Created: 3/14/2019
Status: ❌ Closed

Base: develop ← Head: fix-ip-nat-outside

📝 Commits (1)

  • 999997b Set nat_outside as not required in the IPAddressSerializer

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 netbox/ipam/api/serializers.py (+1 -1)

📄 Description

Fixes:

in 2.5.7, Nat outside is currently defined as a mandatory field in the API specification file
Screen Shot 2019-03-14 at 10 47 14 AM

This PR add the option required=False to the field nat_outside in the IPAddressSerializer to indicate this field as non-mandatory

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3005 **Author:** [@dgarros](https://github.com/dgarros) **Created:** 3/14/2019 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `fix-ip-nat-outside` --- ### 📝 Commits (1) - [`999997b`](https://github.com/netbox-community/netbox/commit/999997b92e3dd5a5598adb63beb276a840d354c3) Set nat_outside as not required in the IPAddressSerializer ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/api/serializers.py` (+1 -1) </details> ### 📄 Description ### Fixes: in 2.5.7, Nat outside is currently defined as a mandatory field in the API specification file <img width="805" alt="Screen Shot 2019-03-14 at 10 47 14 AM" src="https://user-images.githubusercontent.com/304126/54381205-66ef6500-464a-11e9-9369-495c95822be6.png"> This PR add the option `required=False` to the field `nat_outside` in the IPAddressSerializer to indicate this field as non-mandatory --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:21:51 +01:00
adam closed this issue 2025-12-29 22:21:51 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12485
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?