starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #3010] [CLOSED] SAML Authentication #12484

New Issue
Closed
opened 2025-12-29 22:21:50 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:21:50 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/3010
Author: @anthonyeden
Created: 3/15/2019
Status: ❌ Closed

Base: develop ← Head: dev_saml

📝 Commits (3)

  • e4f43f0 Begin work on SAML2 Authentication
  • 04419e8 Include basic SAML setup documentation
  • 6c6eb6f In _record_object_deleted(), don't assert on SAML2 login deletions.

📊 Changes

8 files changed (+106 additions, -1 deletions)

View changed files

📝 .gitignore (+1 -0)
➕ docs/installation/5-saml.md (+58 -0)
📝 docs/installation/index.md (+1 -0)
📝 docs/installation/migrating-to-python3.md (+6 -0)
📝 docs/installation/upgrading.md (+6 -0)
📝 netbox/extras/middleware.py (+3 -1)
📝 netbox/netbox/settings.py (+25 -0)
📝 netbox/netbox/urls.py (+6 -0)

📄 Description

Fixes: #1677

This pull request begins work on including SAML2 Authentication support in NetBox. It relies on the mature project fangli/django-saml2-auth to do the heavy lifting, and includes as few as possible changes to NetBox itself.

I'm submitting this as a draft PR for now so any interested parties can see my progress thus far. However, further work is needed before merging this into the NetBox project. For example, I need to add support for group mapping.

Feedback is welcomed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/3010 **Author:** [@anthonyeden](https://github.com/anthonyeden) **Created:** 3/15/2019 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `dev_saml` --- ### 📝 Commits (3) - [`e4f43f0`](https://github.com/netbox-community/netbox/commit/e4f43f0038f71e300faba72154c2e3c3827378dc) Begin work on SAML2 Authentication - [`04419e8`](https://github.com/netbox-community/netbox/commit/04419e8eaae7d5f63818ce319c962c2e41eb0aa9) Include basic SAML setup documentation - [`6c6eb6f`](https://github.com/netbox-community/netbox/commit/6c6eb6ffd079b77959df58dc80889455be428e75) In _record_object_deleted(), don't assert on SAML2 login deletions. ### 📊 Changes **8 files changed** (+106 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) ➕ `docs/installation/5-saml.md` (+58 -0) 📝 `docs/installation/index.md` (+1 -0) 📝 `docs/installation/migrating-to-python3.md` (+6 -0) 📝 `docs/installation/upgrading.md` (+6 -0) 📝 `netbox/extras/middleware.py` (+3 -1) 📝 `netbox/netbox/settings.py` (+25 -0) 📝 `netbox/netbox/urls.py` (+6 -0) </details> ### 📄 Description ### Fixes: #1677 This pull request begins work on including SAML2 Authentication support in NetBox. It relies on the mature project fangli/django-saml2-auth to do the heavy lifting, and includes as few as possible changes to NetBox itself. I'm submitting this as a draft PR for now so any interested parties can see my progress thus far. However, further work is needed before merging this into the NetBox project. For example, I need to add support for group mapping. Feedback is welcomed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:21:50 +01:00
adam closed this issue 2025-12-29 22:21:51 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12484
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?