[PR #2738] [MERGED] Show exception description on failure to render graphviz #12429

Closed
opened 2025-12-29 22:21:32 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/2738
Author: @candlerb
Created: 1/1/2019
Status: Merged
Merged: 1/16/2019
Merged by: @jeremystretch

Base: developHead: candlerb/graphviz-exception


📝 Commits (1)

  • c581661 Show exception description on failure to render graphviz

📊 Changes

1 file changed (+2 additions, -3 deletions)

View changed files

📝 netbox/extras/api/views.py (+2 -3)

📄 Description

Fixes:

Show the actual exception description when graphviz fails to render.

If the dot executable is missing, the exception now becomes:

There was an error generating the requested graph: failed to execute ['dot', '-Tpng'], make sure the Graphviz executables are on your systems' PATH

which is similar to the current message. But this is not the only problem which can occur; those other problems should now be easier to diagnose.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/2738 **Author:** [@candlerb](https://github.com/candlerb) **Created:** 1/1/2019 **Status:** ✅ Merged **Merged:** 1/16/2019 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `candlerb/graphviz-exception` --- ### 📝 Commits (1) - [`c581661`](https://github.com/netbox-community/netbox/commit/c58166137c6d29c0891a2bb07ad3bc9208b87fd3) Show exception description on failure to render graphviz ### 📊 Changes **1 file changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/api/views.py` (+2 -3) </details> ### 📄 Description ### Fixes: Show the actual exception description when graphviz fails to render. If the dot executable is missing, the exception now becomes: > There was an error generating the requested graph: failed to execute ['dot', '-Tpng'], make sure the Graphviz executables are on your systems' PATH which is similar to the current message. But this is not the only problem which can occur; those other problems should now be easier to diagnose. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:21:32 +01:00
adam closed this issue 2025-12-29 22:21:32 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12429