starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #2546] [MERGED] Update django is_safe_url calls to new API #12402

New Issue
Closed
opened 2025-12-29 22:21:18 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:21:18 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/2546
Author: @jkjuopperi
Created: 11/3/2018
Status: ✅ Merged
Merged: 11/5/2018
Merged by: @jeremystretch

Base: develop-2.5 ← Head: django_is_safe_url

📝 Commits (1)

  • 01f8817 Update django is_safe_url calls to new API

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 netbox/users/views.py (+1 -1)
📝 netbox/utilities/views.py (+3 -3)

📄 Description

Fixes:

Bug #2545: Devopment version uses Django 2.1.3 but uses old is_safe_url API that does not work anymore. The is_safe_url 'host' parameter is now 'allowed_hosts' and accepts either a string or a list of strings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/2546 **Author:** [@jkjuopperi](https://github.com/jkjuopperi) **Created:** 11/3/2018 **Status:** ✅ Merged **Merged:** 11/5/2018 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop-2.5` ← **Head:** `django_is_safe_url` --- ### 📝 Commits (1) - [`01f8817`](https://github.com/netbox-community/netbox/commit/01f8817fd9eff11d7df8ac725599ae649c3e7009) Update django is_safe_url calls to new API ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `netbox/users/views.py` (+1 -1) 📝 `netbox/utilities/views.py` (+3 -3) </details> ### 📄 Description ### Fixes: Bug #2545: Devopment version uses Django 2.1.3 but uses old is_safe_url API that does not work anymore. The is_safe_url 'host' parameter is now 'allowed_hosts' and accepts either a string or a list of strings. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:21:18 +01:00
adam closed this issue 2025-12-29 22:21:18 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12402
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?