starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #2345] [CLOSED] Fixes 2344 - VM not in a Site throws an AttributeError when assigning… #12360

New Issue
Closed
opened 2025-12-29 22:21:04 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:21:04 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/2345
Author: @DanSheps
Created: 8/9/2018
Status: ❌ Closed

Base: develop ← Head: develop

📝 Commits (1)

  • 37cb296 Fixes 2344 - VM not in a Site throws an AttributeError when assigning a VLAN to an interface

📊 Changes

1 file changed (+7 additions, -6 deletions)

View changed files

📝 netbox/dcim/forms.py (+7 -6)

📄 Description

Fixes: #2344

Adds a check for parent.site before attempting to generate Site Group Vlans for the parent site.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/2345 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 8/9/2018 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (1) - [`37cb296`](https://github.com/netbox-community/netbox/commit/37cb296c2301b9a6dfda972ea3d7b0a931031699) Fixes 2344 - VM not in a Site throws an AttributeError when assigning a VLAN to an interface ### 📊 Changes **1 file changed** (+7 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms.py` (+7 -6) </details> ### 📄 Description ### Fixes: #2344 Adds a check for parent.site before attempting to generate Site Group Vlans for the parent site. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:21:04 +01:00
adam closed this issue 2025-12-29 22:21:04 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12360
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?