starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #2204] [MERGED] Fix #2203 - webhook content type check #12329

New Issue
Closed
opened 2025-12-29 22:20:54 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:20:54 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/2204
Author: @lampwins
Created: 6/27/2018
Status: ✅ Merged
Merged: 6/29/2018
Merged by: @jeremystretch

Base: develop-2.4 ← Head: bug/2203

📝 Commits (1)

📊 Changes

4 files changed (+14 additions, -61 deletions)

View changed files

📝 netbox/extras/apps.py (+0 -2)
➖ netbox/extras/signals.py (+0 -16)
📝 netbox/extras/webhooks.py (+14 -35)
📝 netbox/netbox/settings.py (+0 -8)

📄 Description

Fixes: #2203

This PR covers two things, a fix for #2203 (simple logic error) and removal of the cache layer for webhooks.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/2204 **Author:** [@lampwins](https://github.com/lampwins) **Created:** 6/27/2018 **Status:** ✅ Merged **Merged:** 6/29/2018 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop-2.4` ← **Head:** `bug/2203` --- ### 📝 Commits (1) - [`65e18e0`](https://github.com/netbox-community/netbox/commit/65e18e057f4bc52c0fbc35feb765cdb2a674514e) fixed #2203 ### 📊 Changes **4 files changed** (+14 additions, -61 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/apps.py` (+0 -2) ➖ `netbox/extras/signals.py` (+0 -16) 📝 `netbox/extras/webhooks.py` (+14 -35) 📝 `netbox/netbox/settings.py` (+0 -8) </details> ### 📄 Description <!-- Thank you for your interest in contributing to NetBox! Please note that our contribution policy requires that a feature request or bug report be opened for approval prior to filing a pull request. This helps avoid wasting time and effort on something that we might not be able to accept. Please indicate the relevant feature request or bug report below. --> ### Fixes: #2203 <!-- Please include a summary of the proposed changes below. --> This PR covers two things, a fix for #2203 (simple logic error) and removal of the cache layer for webhooks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:20:54 +01:00
adam closed this issue 2025-12-29 22:20:54 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12329
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?