starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #2158] [MERGED] Fixes #2157: Natural ordering breaks when sorting objects by name #12321

New Issue
Closed
opened 2025-12-29 22:20:52 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:20:52 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/2158
Author: @jeremystretch
Created: 6/11/2018
Status: ✅ Merged
Merged: 6/11/2018
Merged by: @jeremystretch

Base: develop-2.4 ← Head: 2157-natural-ordering

📝 Commits (1)

  • 90abeed Fix natural ordering within object tables

📊 Changes

3 files changed (+33 additions, -30 deletions)

View changed files

📝 netbox/dcim/models.py (+3 -9)
📝 netbox/dcim/tables.py (+6 -3)
📝 netbox/utilities/managers.py (+24 -18)

📄 Description

Fixes: #2157

Reworked NaturalOrderByManager to intelligently replace references of the designated natural ordering field with its three subfields.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/2158 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 6/11/2018 **Status:** ✅ Merged **Merged:** 6/11/2018 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop-2.4` ← **Head:** `2157-natural-ordering` --- ### 📝 Commits (1) - [`90abeed`](https://github.com/netbox-community/netbox/commit/90abeedc3e81fdc95e8b73d098e66c1a4d9c4352) Fix natural ordering within object tables ### 📊 Changes **3 files changed** (+33 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/models.py` (+3 -9) 📝 `netbox/dcim/tables.py` (+6 -3) 📝 `netbox/utilities/managers.py` (+24 -18) </details> ### 📄 Description ### Fixes: #2157 Reworked NaturalOrderByManager to intelligently replace references of the designated natural ordering field with its three subfields. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:20:52 +01:00
adam closed this issue 2025-12-29 22:20:52 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12321
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?