starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #1969] [CLOSED] Use relative paths #12290

New Issue
Closed
opened 2025-12-29 22:20:41 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:20:41 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/1969
Author: @logan2211
Created: 3/15/2018
Status: ❌ Closed

Base: develop ← Head: relative-paths

📝 Commits (1)

📊 Changes

4 files changed (+6 additions, -6 deletions)

View changed files

📝 netbox/netbox/settings.py (+3 -3)
📝 netbox/templates/_base.html (+1 -1)
📝 netbox/templates/rest_framework/api.html (+1 -1)
📝 netbox/utilities/forms.py (+1 -1)

📄 Description

Relative paths are helpful when running netbox behind a load balancer
where the client's path may not match what the server receives.

BASE_PATH can still be used to mimic the current behavior by setting:
BASE_PATH = '/'

Fixes:

Situation where the client is loading ex. /netbox but the netbox app is not aware it is behind a LB, and instead is serving from /. The LB in this case is responsible for path stripping the /netbox to /, but due to how netbox serves the requests it will link all of the static content using / which is not valid.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/1969 **Author:** [@logan2211](https://github.com/logan2211) **Created:** 3/15/2018 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `relative-paths` --- ### 📝 Commits (1) - [`e23a785`](https://github.com/netbox-community/netbox/commit/e23a785a14f1bcb3194f86cc45e9d9f7b71ad91e) Use relative paths ### 📊 Changes **4 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/settings.py` (+3 -3) 📝 `netbox/templates/_base.html` (+1 -1) 📝 `netbox/templates/rest_framework/api.html` (+1 -1) 📝 `netbox/utilities/forms.py` (+1 -1) </details> ### 📄 Description Relative paths are helpful when running netbox behind a load balancer where the client's path may not match what the server receives. BASE_PATH can still be used to mimic the current behavior by setting: BASE_PATH = '/' <!-- Thank you for your interest in contributing to NetBox! Please note that our contribution policy requires that a feature request or bug report be opened for approval prior to filing a pull request. This helps avoid wasting time and effort on something that we might not be able to accept. Please indicate the relevant feature request or bug report below. --> ### Fixes: Situation where the client is loading ex. /netbox but the netbox app is not aware it is behind a LB, and instead is serving from /. The LB in this case is responsible for path stripping the /netbox to /, but due to how netbox serves the requests it will link all of the static content using / which is not valid. <!-- Please include a summary of the proposed changes below. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:20:41 +01:00
adam closed this issue 2025-12-29 22:20:41 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12290
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?