starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #1925] [MERGED] fixed #1921 - create interfaces with 802.1q in api #12284

New Issue
Closed
opened 2025-12-29 22:20:39 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:20:39 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/1925
Author: @lampwins
Created: 2/27/2018
Status: ✅ Merged
Merged: 3/1/2018
Merged by: @jeremystretch

Base: develop ← Head: bug/1921

📝 Commits (4)

  • e4c1cec fixed #1921 - create interfaces with 801.1q in api
  • 0357d85 Merge branch 'develop' into bug/1921
  • b34f4f8 refactor to handle M2M validation in ValidatedModelSerializer
  • 19831f0 Merge branch 'develop' into bug/1921

📊 Changes

2 files changed (+64 additions, -1 deletions)

View changed files

📝 netbox/dcim/api/serializers.py (+1 -1)
📝 netbox/dcim/tests/test_api.py (+63 -0)

📄 Description

Fixes: #1921

Implemented the create() method on the WritableInterfaceSerializer and the updated the logic in validate() to account for tagged_vlans being a Many-to-Many relationships. Also added some tests to cover this :)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/1925 **Author:** [@lampwins](https://github.com/lampwins) **Created:** 2/27/2018 **Status:** ✅ Merged **Merged:** 3/1/2018 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `bug/1921` --- ### 📝 Commits (4) - [`e4c1cec`](https://github.com/netbox-community/netbox/commit/e4c1cece75475052c97c7050c47997472a9262e2) fixed #1921 - create interfaces with 801.1q in api - [`0357d85`](https://github.com/netbox-community/netbox/commit/0357d8522cbbc8a294df46be181e586b7540cfe0) Merge branch 'develop' into bug/1921 - [`b34f4f8`](https://github.com/netbox-community/netbox/commit/b34f4f8e4318512139a6f985357ea8ce04b506e3) refactor to handle M2M validation in ValidatedModelSerializer - [`19831f0`](https://github.com/netbox-community/netbox/commit/19831f01775cdf7872dcd9c2bc39514c2be12af6) Merge branch 'develop' into bug/1921 ### 📊 Changes **2 files changed** (+64 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/api/serializers.py` (+1 -1) 📝 `netbox/dcim/tests/test_api.py` (+63 -0) </details> ### 📄 Description <!-- Thank you for your interest in contributing to NetBox! Please note that our contribution policy requires that a feature request or bug report be opened for approval prior to filing a pull request. This helps avoid wasting time and effort on something that we might not be able to accept. Please indicate the relevant feature request or bug report below. --> ### Fixes: #1921 Implemented the `create()` method on the `WritableInterfaceSerializer` and the updated the logic in `validate()` to account for `tagged_vlans` being a Many-to-Many relationships. Also added some tests to cover this :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:20:39 +01:00
adam closed this issue 2025-12-29 22:20:39 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12284
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?