starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #1748] [CLOSED] Serial and console form factors #12259

New Issue
Closed
opened 2025-12-29 22:20:31 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:20:31 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/1748
Author: @explody
Created: 12/4/2017
Status: ❌ Closed

Base: develop ← Head: serial_and_console_form_factors

📝 Commits (3)

  • df8a9a2 Added form factors for console and console server port instances and templates. Added additional serial form factors
  • 6a9ae22 Added console related form_factor fields to API serializers
  • f9f388f Migration for new form factors. Also updated device templates to display FF correctly in the console/power table

📊 Changes

8 files changed (+144 additions, -18 deletions)

View changed files

📝 netbox/dcim/api/serializers.py (+8 -8)
📝 netbox/dcim/constants.py (+40 -0)
📝 netbox/dcim/forms.py (+9 -5)
➕ netbox/dcim/migrations/0050_serial_and_console_form_factors.py (+73 -0)
📝 netbox/dcim/models.py (+7 -3)
📝 netbox/dcim/tables.py (+2 -2)
📝 netbox/templates/dcim/inc/consoleport.html (+3 -0)
📝 netbox/templates/dcim/inc/powerport.html (+2 -0)

📄 Description

Fixes:

Addresses #167 though I could add a new issue if preferred

This PR adds two enhancements

  • 3 Additional form factors for serial network interfaces

    • DE9
    • DB25
    • RJ45

  • Adds form factor selection for console ports and console server ports as well as their related templates.

    • RJ45
    • DE9
    • DB25
    • USB to Serial
    • Micro USB to Serial
    • Mini USB to Serial
    • KVM

The rationale here is that even now, there are machines with call-home on landlines that use serial-to-modem for that connection. In particular, door access control systems and the like in our DCs and telco spaces often have old or unusual connections. The added serial types cover the most common.

For the console port form factors, it is because we determined that nearly every device we found has one or more console ports, but not all the same type or quantity of each. Specifying a FF for the console connections allows a user to more thoroughly plan interconnections between devices such as with network, without, IMHO, bogging down in too much detail.

I added the FF to the console port table, but I did not enable bulk editing since there's really only the one setting per port. Might make sense later if it were worthwhile to record baud rate or other serial settings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/1748 **Author:** [@explody](https://github.com/explody) **Created:** 12/4/2017 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `serial_and_console_form_factors` --- ### 📝 Commits (3) - [`df8a9a2`](https://github.com/netbox-community/netbox/commit/df8a9a2c9a1eaa6aa5f4f57a4692efc4c6cb9cf9) Added form factors for console and console server port instances and templates. Added additional serial form factors - [`6a9ae22`](https://github.com/netbox-community/netbox/commit/6a9ae224220bcf4344f406bd0e42c773a0d2d482) Added console related form_factor fields to API serializers - [`f9f388f`](https://github.com/netbox-community/netbox/commit/f9f388f2ad6a9d40cffb45be5231a70092d7c51e) Migration for new form factors. Also updated device templates to display FF correctly in the console/power table ### 📊 Changes **8 files changed** (+144 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/api/serializers.py` (+8 -8) 📝 `netbox/dcim/constants.py` (+40 -0) 📝 `netbox/dcim/forms.py` (+9 -5) ➕ `netbox/dcim/migrations/0050_serial_and_console_form_factors.py` (+73 -0) 📝 `netbox/dcim/models.py` (+7 -3) 📝 `netbox/dcim/tables.py` (+2 -2) 📝 `netbox/templates/dcim/inc/consoleport.html` (+3 -0) 📝 `netbox/templates/dcim/inc/powerport.html` (+2 -0) </details> ### 📄 Description ### Fixes: Addresses #167 though I could add a new issue if preferred <!-- Please include a summary of the proposed changes below. --> This PR adds two enhancements * 3 Additional form factors for serial network interfaces * DE9 * DB25 * RJ45 * Adds form factor selection for console ports and console server ports as well as their related templates. * RJ45 * DE9 * DB25 * USB to Serial * Micro USB to Serial * Mini USB to Serial * KVM The rationale here is that even now, there are machines with call-home on landlines that use serial-to-modem for that connection. In particular, door access control systems and the like in our DCs and telco spaces often have old or unusual connections. The added serial types cover the most common. For the console port form factors, it is because we determined that nearly every device we found has one or more console ports, but not all the same type or quantity of each. Specifying a FF for the console connections allows a user to more thoroughly plan interconnections between devices such as with network, without, IMHO, bogging down in too much detail. I added the FF to the console port table, but I did not enable bulk editing since there's really only the one setting per port. Might make sense later if it were worthwhile to record baud rate or other serial settings. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:20:31 +01:00
adam closed this issue 2025-12-29 22:20:32 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12259
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?