starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #1656] [MERGED] Fixes #1655. Removed explicit field references. #12242

New Issue
Closed
opened 2025-12-29 22:20:26 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:20:26 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/1656
Author: @Ichabond
Created: 10/27/2017
Status: ✅ Merged
Merged: 11/2/2017
Merged by: @jeremystretch

Base: develop ← Head: develop

📝 Commits (3)

📊 Changes

18 files changed (+37 additions, -34 deletions)

View changed files

📝 netbox/secrets/models.py (+3 -0)
📝 netbox/templates/circuits/circuit.html (+1 -1)
📝 netbox/templates/dcim/device.html (+4 -4)
📝 netbox/templates/dcim/devicebay_populate.html (+1 -1)
📝 netbox/templates/dcim/inc/consoleport.html (+2 -2)
📝 netbox/templates/dcim/inc/consoleserverport.html (+1 -1)
📝 netbox/templates/dcim/inc/device_header.html (+1 -1)
📝 netbox/templates/dcim/inc/devicebay.html (+1 -1)
📝 netbox/templates/dcim/inc/interface.html (+2 -2)
📝 netbox/templates/dcim/inc/inventoryitem.html (+1 -1)
📝 netbox/templates/dcim/inc/poweroutlet.html (+2 -2)
📝 netbox/templates/dcim/inc/powerport.html (+2 -2)
📝 netbox/templates/dcim/rack.html (+4 -4)
📝 netbox/templates/dcim/site.html (+2 -2)
📝 netbox/templates/ipam/prefix.html (+3 -3)
📝 netbox/templates/ipam/vlan.html (+4 -4)
📝 netbox/templates/virtualization/inc/interface.html (+1 -1)
📝 netbox/templates/virtualization/virtualmachine.html (+2 -2)

📄 Description

Fixes:

Fixes #1655

All .name references are now removed where applicable (eg. not in the detailed description, as that's an explicit UI reference to .name, so might not work well with __str__). Updated the Secrets __str__ method, as this was lacking a reference to name, which felt oddly lacking.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/1656 **Author:** [@Ichabond](https://github.com/Ichabond) **Created:** 10/27/2017 **Status:** ✅ Merged **Merged:** 11/2/2017 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (3) - [`e26a057`](https://github.com/netbox-community/netbox/commit/e26a0574bac03709dc1f4693878881ef626394ef) Fixes #1655 - [`bd276aa`](https://github.com/netbox-community/netbox/commit/bd276aae20963eb3d7fc4a87444761b35b037219) Fixes #1655: Removed explicit field references - [`1a61941`](https://github.com/netbox-community/netbox/commit/1a61941ed3278fcc2bfba1675524c7b3d063b825) Adapted PR to comply with comments ### 📊 Changes **18 files changed** (+37 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `netbox/secrets/models.py` (+3 -0) 📝 `netbox/templates/circuits/circuit.html` (+1 -1) 📝 `netbox/templates/dcim/device.html` (+4 -4) 📝 `netbox/templates/dcim/devicebay_populate.html` (+1 -1) 📝 `netbox/templates/dcim/inc/consoleport.html` (+2 -2) 📝 `netbox/templates/dcim/inc/consoleserverport.html` (+1 -1) 📝 `netbox/templates/dcim/inc/device_header.html` (+1 -1) 📝 `netbox/templates/dcim/inc/devicebay.html` (+1 -1) 📝 `netbox/templates/dcim/inc/interface.html` (+2 -2) 📝 `netbox/templates/dcim/inc/inventoryitem.html` (+1 -1) 📝 `netbox/templates/dcim/inc/poweroutlet.html` (+2 -2) 📝 `netbox/templates/dcim/inc/powerport.html` (+2 -2) 📝 `netbox/templates/dcim/rack.html` (+4 -4) 📝 `netbox/templates/dcim/site.html` (+2 -2) 📝 `netbox/templates/ipam/prefix.html` (+3 -3) 📝 `netbox/templates/ipam/vlan.html` (+4 -4) 📝 `netbox/templates/virtualization/inc/interface.html` (+1 -1) 📝 `netbox/templates/virtualization/virtualmachine.html` (+2 -2) </details> ### 📄 Description ### Fixes: Fixes #1655 All .name references are now removed where applicable (eg. not in the detailed description, as that's an explicit UI reference to .name, so might not work well with `__str__`). Updated the `Secrets` `__str__` method, as this was lacking a reference to `name`, which felt oddly lacking. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:20:26 +01:00
adam closed this issue 2025-12-29 22:20:27 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12242
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?