[PR #1598] [MERGED] Avoid creating repeated graph nodes where device matches multiple regexps #12233

New Issue

adam · 2025-12-29T22:20:23+01:00

adam commented

2025-12-29 22:20:23 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/1598
Author: @candlerb
Created: 10/16/2017
Status: ✅ Merged
Merged: 10/16/2017
Merged by: @jeremystretch

Base: develop ← Head: candlerb/1498

📝 Commits (1)

5fc3eac Avoid creating repeated graph nodes where device matches multiple regexps

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 netbox/extras/models.py (+4 -0)

📄 Description

Fixes: #1498

When generating graphviz output, don't output a node which has been output previously.

In fact, if graphviz sees a node with the same name more than once, it will be counted as the same node, so it will only appear once on the graph anyway. But it will appear in an unexpected place if it matches more than one regexp in the same topology map; this change makes it appear in the first row where it matches.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/1598 **Author:** [@candlerb](https://github.com/candlerb) **Created:** 10/16/2017 **Status:** ✅ Merged **Merged:** 10/16/2017 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `candlerb/1498` --- ### 📝 Commits (1) - [`5fc3eac`](https://github.com/netbox-community/netbox/commit/5fc3eac0f669fccd0fae89ce84aa862bbcbe9af2) Avoid creating repeated graph nodes where device matches multiple regexps ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/models.py` (+4 -0) </details> ### 📄 Description ### Fixes: #1498 When generating graphviz output, don't output a node which has been output previously. In fact, if graphviz sees a node with the same name more than once, it will be counted as the same node, so it will only appear once on the graph anyway. But it will appear in an unexpected place if it matches more than one regexp in the same topology map; this change makes it appear in the first row where it matches. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 22:20:23 +01:00

adam closed this issue

2025-12-29 22:20:23 +01:00

adam referenced this issue

2025-12-29 23:21:56 +01:00

[PR #12502] [MERGED] Moves related ips to a tab #13992

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#12233