starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #1487] [MERGED] WIP: implements #150 interface vlan mapping #12210

New Issue
Closed
opened 2025-12-29 22:20:16 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:20:16 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/1487
Author: @lampwins
Created: 9/14/2017
Status: ✅ Merged
Merged: 11/6/2017
Merged by: @jeremystretch

Base: 150-interface-vlans ← Head: develop

📝 Commits (4)

  • 2335b90 implements #150 - inteface vlan tagging
  • a621912 test fix. allow validated model serializer to specify certain fields to ignore validation on.
  • 24f0620 PEP8 fix; removed commented out code
  • 26ff6d6 PEP8 fix; newline in contants

📊 Changes

10 files changed (+442 additions, -59 deletions)

View changed files

📝 netbox/dcim/api/serializers.py (+45 -2)
📝 netbox/dcim/constants.py (+9 -0)
📝 netbox/dcim/forms.py (+251 -10)
➕ netbox/dcim/migrations/0049_interface_vlan_tagging.py (+32 -0)
📝 netbox/dcim/models.py (+14 -0)
📝 netbox/project-static/js/forms.js (+53 -47)
📝 netbox/utilities/api.py (+5 -0)
➕ netbox/utilities/constants.py (+7 -0)
📝 netbox/utilities/views.py (+20 -0)
📝 netbox/virtualization/models.py (+6 -0)

📄 Description

Fixes: #150

The dcim Interface model as three new fields. mode, native_vlan and tagged_vlan_members. Note that tagged_vlan_members is a ManyToMany relationship to ipam VLAN. This includes all associated migration, view, form, model, and api changes. Submitted as a WIP for review.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/1487 **Author:** [@lampwins](https://github.com/lampwins) **Created:** 9/14/2017 **Status:** ✅ Merged **Merged:** 11/6/2017 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `150-interface-vlans` ← **Head:** `develop` --- ### 📝 Commits (4) - [`2335b90`](https://github.com/netbox-community/netbox/commit/2335b90e29a3ed85975546120c750aaf6a42cede) implements #150 - inteface vlan tagging - [`a621912`](https://github.com/netbox-community/netbox/commit/a621912396f027509a04f85a45d50ec4fce7e886) test fix. allow validated model serializer to specify certain fields to ignore validation on. - [`24f0620`](https://github.com/netbox-community/netbox/commit/24f062007feb940dcddd9801e3ae0bfc5b4cbcf9) PEP8 fix; removed commented out code - [`26ff6d6`](https://github.com/netbox-community/netbox/commit/26ff6d6a1482a4c5dd23197ea5afa63f98127db7) PEP8 fix; newline in contants ### 📊 Changes **10 files changed** (+442 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/api/serializers.py` (+45 -2) 📝 `netbox/dcim/constants.py` (+9 -0) 📝 `netbox/dcim/forms.py` (+251 -10) ➕ `netbox/dcim/migrations/0049_interface_vlan_tagging.py` (+32 -0) 📝 `netbox/dcim/models.py` (+14 -0) 📝 `netbox/project-static/js/forms.js` (+53 -47) 📝 `netbox/utilities/api.py` (+5 -0) ➕ `netbox/utilities/constants.py` (+7 -0) 📝 `netbox/utilities/views.py` (+20 -0) 📝 `netbox/virtualization/models.py` (+6 -0) </details> ### 📄 Description <!-- Thank you for your interest in contributing to NetBox! Please note that our contribution policy requires that a feature request or bug report be opened for approval prior to filing a pull request. This helps avoid wasting time and effort on something that we might not be able to accept. Please indicate the relevant feature request or bug report below. --> ### Fixes: #150 <!-- Please include a summary of the proposed changes below. --> The dcim `Interface` model as three new fields. `mode`, `native_vlan` and `tagged_vlan_members`. Note that `tagged_vlan_members` is a ManyToMany relationship to ipam `VLAN`. This includes all associated migration, view, form, model, and api changes. Submitted as a WIP for review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:20:16 +01:00
adam closed this issue 2025-12-29 22:20:16 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12210
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?