starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #1040] [CLOSED] Assign IP Address to Interface from Interface List and Add IP addresses to the interface list #12153

New Issue
Closed
opened 2025-12-29 22:19:55 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:19:55 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/1040
Author: @snazy2000
Created: 4/5/2017
Status: ❌ Closed

Base: develop ← Head: develop

📝 Commits (6)

  • cc99d47 Assign IP Address to Interface from Interface List
  • 67a17e3 Merge pull request #1 from digitalocean/develop
  • 4932e02 Merge pull request #2 from digitalocean/develop
  • 67ba5a5 Ability to edit IP address and Interface from within devices
  • 4a685da PEP 8 Errors
  • b47b174 Damn PEP8...

📊 Changes

7 files changed (+54 additions, -18 deletions)

View changed files

📝 netbox/dcim/views.py (+3 -1)
📝 netbox/ipam/forms.py (+10 -1)
📝 netbox/ipam/views.py (+1 -1)
📝 netbox/templates/dcim/inc/interface.html (+23 -2)
📝 netbox/templates/dcim/inc/ipaddress.html (+5 -0)
📝 netbox/templates/ipam/ipaddress_edit.html (+6 -12)
📝 netbox/utilities/views.py (+6 -1)

📄 Description

Fixes: Partially Fixes #1001 and #878

image

I've changed the connect and disconnect buttons to arrows as looked like Connecting and disconnecting a cable

I've also added the + which adds an IP address, could get rid of the IP address section if we added the delete button next to the IP Address?

I've had a good feedback from people I work with about the change

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/1040 **Author:** [@snazy2000](https://github.com/snazy2000) **Created:** 4/5/2017 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (6) - [`cc99d47`](https://github.com/netbox-community/netbox/commit/cc99d471906bc817f54733fe9df89e31a6f3bb14) Assign IP Address to Interface from Interface List - [`67a17e3`](https://github.com/netbox-community/netbox/commit/67a17e3adf809ef07a7174e8ded4d421d848e194) Merge pull request #1 from digitalocean/develop - [`4932e02`](https://github.com/netbox-community/netbox/commit/4932e023a0e1b6c70191db65cf0844d630ae68b9) Merge pull request #2 from digitalocean/develop - [`67ba5a5`](https://github.com/netbox-community/netbox/commit/67ba5a59547ca6ed8d728e9dd9fd347c6384bb82) Ability to edit IP address and Interface from within devices - [`4a685da`](https://github.com/netbox-community/netbox/commit/4a685da2693399d4dcca9fc2cc68d2ab463124f6) PEP 8 Errors - [`b47b174`](https://github.com/netbox-community/netbox/commit/b47b1743f7971f53ac3f27c011c71d6724074f43) Damn PEP8... ### 📊 Changes **7 files changed** (+54 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/views.py` (+3 -1) 📝 `netbox/ipam/forms.py` (+10 -1) 📝 `netbox/ipam/views.py` (+1 -1) 📝 `netbox/templates/dcim/inc/interface.html` (+23 -2) 📝 `netbox/templates/dcim/inc/ipaddress.html` (+5 -0) 📝 `netbox/templates/ipam/ipaddress_edit.html` (+6 -12) 📝 `netbox/utilities/views.py` (+6 -1) </details> ### 📄 Description ### Fixes: Partially Fixes #1001 and #878 ![image](https://cloud.githubusercontent.com/assets/1378836/24712722/8da5fe64-1a1b-11e7-91fb-41e550cf1245.png) I've changed the connect and disconnect buttons to arrows as looked like Connecting and disconnecting a cable I've also added the + which adds an IP address, could get rid of the IP address section if we added the delete button next to the IP Address? I've had a good feedback from people I work with about the change --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:19:55 +01:00
adam closed this issue 2025-12-29 22:19:55 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12153
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?