starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #997] [MERGED] Fixes #996 #12143

New Issue
Closed
opened 2025-12-29 22:19:52 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:19:52 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/997
Author: @zachmoody
Created: 3/24/2017
Status: ✅ Merged
Merged: 3/27/2017
Merged by: @jeremystretch

Base: v2-develop ← Head: livesearch-fix

📝 Commits (3)

📊 Changes

4 files changed (+15 additions, -15 deletions)

View changed files

📝 netbox/circuits/forms.py (+2 -2)
📝 netbox/dcim/forms.py (+10 -10)
📝 netbox/ipam/forms.py (+2 -2)
📝 netbox/project-static/js/livesearch.js (+1 -1)

📄 Description

Fixes:

#996

Updates dcim api url provided to livesearch.js.
Modifies livesearch.js to look for results in data.results.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/997 **Author:** [@zachmoody](https://github.com/zachmoody) **Created:** 3/24/2017 **Status:** ✅ Merged **Merged:** 3/27/2017 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `v2-develop` ← **Head:** `livesearch-fix` --- ### 📝 Commits (3) - [`48141c0`](https://github.com/netbox-community/netbox/commit/48141c06930f19e9fd2f39f378c42fd463dbd44b) Fixes #996 - [`066a3b8`](https://github.com/netbox-community/netbox/commit/066a3b8b5234d907c6b638b689ed1b8902726201) update `api_url` with new interfaces endpoint. - [`22bfac7`](https://github.com/netbox-community/netbox/commit/22bfac746ef17b22ea757fc104f634ce76cc4e29) fix remaining legacy api url paths. ### 📊 Changes **4 files changed** (+15 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/forms.py` (+2 -2) 📝 `netbox/dcim/forms.py` (+10 -10) 📝 `netbox/ipam/forms.py` (+2 -2) 📝 `netbox/project-static/js/livesearch.js` (+1 -1) </details> ### 📄 Description <!-- Thank you for your interest in contributing to NetBox! Please note that our contribution policy requires that a feature request or bug report be opened for approval prior to filing a pull request. This helps avoid wasting time and effort on something that we might not be able to accept. Please indicate the relevant feature request or bug report below. --> ### Fixes: #996 <!-- Please include a summary of the proposed changes below. --> Updates dcim api url provided to livesearch.js. Modifies livesearch.js to look for results in `data.results`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:19:52 +01:00
adam closed this issue 2025-12-29 22:19:52 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12143
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?