starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #794] [CLOSED] Fix #235: Enable global vlan #12115

New Issue
Closed
opened 2025-12-29 22:19:42 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:19:42 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/794
Author: @peng-shawn
Created: 1/13/2017
Status: ❌ Closed

Base: develop ← Head: global-vlan

📝 Commits (10+)

  • c2793e9 Enable global vlan
  • 97c0f23 Add description field to TenantSerializer
  • 466c505 Corrected PEP8 errors
  • 98e2145 Merge pull request #796 from rburkholder/rburkholder-patch-TenantSerializer-description
  • 4654770 Enable global vlan, follow up
  • cfaf8b9 added duplicates() method to IPAddress and Prefix model managers.
  • eedec19 Added model tests for duplicate prefix and IPs.
  • 485a21f cleaned up IPAddress clean() to be more like Prefix's
  • edf29e7 moved duplicates() method to model instead of manager.
  • 398faf5 Merge pull request #804 from digitalocean/prefix-unique

📊 Changes

128 files changed (+2113 additions, -949 deletions)

View changed files

📝 .gitignore (+2 -0)
📝 .travis.yml (+3 -0)
📝 docs/installation/netbox.md (+17 -0)
📝 docs/installation/upgrading.md (+6 -0)
📝 netbox/circuits/__init__.py (+1 -0)
📝 netbox/circuits/api/serializers.py (+2 -1)
➕ netbox/circuits/apps.py (+9 -0)
📝 netbox/circuits/filters.py (+1 -0)
📝 netbox/circuits/forms.py (+48 -15)
➕ netbox/circuits/migrations/0007_circuit_add_description.py (+20 -0)
📝 netbox/circuits/models.py (+11 -7)
➕ netbox/circuits/signals.py (+13 -0)
📝 netbox/circuits/tables.py (+2 -3)
📝 netbox/circuits/views.py (+28 -22)
📝 netbox/dcim/admin.py (+6 -1)
📝 netbox/dcim/api/serializers.py (+30 -7)
📝 netbox/dcim/api/urls.py (+4 -0)
📝 netbox/dcim/api/views.py (+27 -4)
📝 netbox/dcim/filters.py (+16 -4)
📝 netbox/dcim/fixtures/dcim.json (+11 -0)

...and 80 more files

📄 Description

  1. Decouple site/vlan, make site optional for vlan/vlangroup
  2. Change html generation code to check site existence before
    dereference
  3. Create site search function, if site is None for a VLAN, view it as
    global VLAN

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/794 **Author:** [@peng-shawn](https://github.com/peng-shawn) **Created:** 1/13/2017 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `global-vlan` --- ### 📝 Commits (10+) - [`c2793e9`](https://github.com/netbox-community/netbox/commit/c2793e90dc1191ed21d50a10f138818e6f889d88) Enable global vlan - [`97c0f23`](https://github.com/netbox-community/netbox/commit/97c0f23c676de7e726e938bf0b61087834cf9fd9) Add description field to TenantSerializer - [`466c505`](https://github.com/netbox-community/netbox/commit/466c505bb88fda2e12471343e16fe0250817fe15) Corrected PEP8 errors - [`98e2145`](https://github.com/netbox-community/netbox/commit/98e2145b526691d8bf3d5af5efa9d90b186b291c) Merge pull request #796 from rburkholder/rburkholder-patch-TenantSerializer-description - [`4654770`](https://github.com/netbox-community/netbox/commit/465477057b1160f50013fa77c1a34c64bd5a9099) Enable global vlan, follow up - [`cfaf8b9`](https://github.com/netbox-community/netbox/commit/cfaf8b9157db535a5289a656188628842c781ddb) added duplicates() method to IPAddress and Prefix model managers. - [`eedec19`](https://github.com/netbox-community/netbox/commit/eedec192ba0a21c09f1108b61cd590a0bb679820) Added model tests for duplicate prefix and IPs. - [`485a21f`](https://github.com/netbox-community/netbox/commit/485a21f13ee73c25ccd99a029a4f3616eee35bc2) cleaned up IPAddress clean() to be more like Prefix's - [`edf29e7`](https://github.com/netbox-community/netbox/commit/edf29e7b9b38821650dbba6a762b188a44948558) moved duplicates() method to model instead of manager. - [`398faf5`](https://github.com/netbox-community/netbox/commit/398faf518ce5384f6e4962cd5cdaf3cd58b12459) Merge pull request #804 from digitalocean/prefix-unique ### 📊 Changes **128 files changed** (+2113 additions, -949 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -0) 📝 `.travis.yml` (+3 -0) 📝 `docs/installation/netbox.md` (+17 -0) 📝 `docs/installation/upgrading.md` (+6 -0) 📝 `netbox/circuits/__init__.py` (+1 -0) 📝 `netbox/circuits/api/serializers.py` (+2 -1) ➕ `netbox/circuits/apps.py` (+9 -0) 📝 `netbox/circuits/filters.py` (+1 -0) 📝 `netbox/circuits/forms.py` (+48 -15) ➕ `netbox/circuits/migrations/0007_circuit_add_description.py` (+20 -0) 📝 `netbox/circuits/models.py` (+11 -7) ➕ `netbox/circuits/signals.py` (+13 -0) 📝 `netbox/circuits/tables.py` (+2 -3) 📝 `netbox/circuits/views.py` (+28 -22) 📝 `netbox/dcim/admin.py` (+6 -1) 📝 `netbox/dcim/api/serializers.py` (+30 -7) 📝 `netbox/dcim/api/urls.py` (+4 -0) 📝 `netbox/dcim/api/views.py` (+27 -4) 📝 `netbox/dcim/filters.py` (+16 -4) 📝 `netbox/dcim/fixtures/dcim.json` (+11 -0) _...and 80 more files_ </details> ### 📄 Description 1. Decouple site/vlan, make site optional for vlan/vlangroup 2. Change html generation code to check site existence before dereference 3. Create site search function, if site is None for a VLAN, view it as global VLAN --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:19:42 +01:00
adam closed this issue 2025-12-29 22:19:42 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12115
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?