starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #556] [CLOSED] Multipoint circuits #12077

New Issue
Closed
opened 2025-12-29 22:19:30 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:19:30 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/556
Author: @nlgotz
Created: 9/14/2016
Status: ❌ Closed

Base: develop ← Head: multipoint_circuits

📝 Commits (10+)

  • 36f615d Add Multipoint terminations to a circuit
  • 2ccaae4 Undo change to .gitignore
  • 08bc5df Fixed provider filter by site name
  • 5b78bb0 Fixed Multipoint filtering
  • 510bf5c Fixed PEP8 issues with multipoint circuits
  • bbc4283 Merge remote-tracking branch 'upstream/develop' into multipoint_circuits
  • 3d59b40 Re-added terminations to forms.py
  • 047ccaa Fixed pep8 error
  • 6510c6e Fixed issues with terminations in dcim and APIs
  • ffe374c Modified gitignore to not include gunicorn

📊 Changes

29 files changed (+552 additions, -182 deletions)

View changed files

📝 .gitignore (+3 -0)
📝 netbox/circuits/admin.py (+15 -5)
📝 netbox/circuits/api/serializers.py (+1 -4)
📝 netbox/circuits/api/views.py (+2 -2)
📝 netbox/circuits/filters.py (+3 -16)
📝 netbox/circuits/forms.py (+114 -6)
➕ netbox/circuits/migrations/0006_auto_20160908_0213.py (+42 -0)
➕ netbox/circuits/migrations/0007_auto_20160908_0220.py (+43 -0)
➕ netbox/circuits/migrations/0008_remove_termination_comments.py (+19 -0)
➕ netbox/circuits/migrations/0009_termination_comments.py (+20 -0)
📝 netbox/circuits/models.py (+37 -12)
📝 netbox/circuits/tables.py (+3 -6)
📝 netbox/circuits/urls.py (+5 -0)
📝 netbox/circuits/views.py (+69 -4)
📝 netbox/dcim/api/serializers.py (+1 -1)
📝 netbox/dcim/api/views.py (+1 -1)
📝 netbox/dcim/forms.py (+3 -3)
📝 netbox/dcim/models.py (+2 -2)
📝 netbox/dcim/tests/test_apis.py (+0 -1)
📝 netbox/dcim/views.py (+4 -4)

...and 9 more files

📄 Description

From #49.

This allows end users to create multipoint circuits. There is a new class in the circuits model called Terminations. It takes most of the items from circuits. Since a circuit could have different port speeds/commit rates on different terminations, that was removed from the circuits class and added to Terminations.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/556 **Author:** [@nlgotz](https://github.com/nlgotz) **Created:** 9/14/2016 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `multipoint_circuits` --- ### 📝 Commits (10+) - [`36f615d`](https://github.com/netbox-community/netbox/commit/36f615d1c4e1ab103ca13d517731b98a7130a5f0) Add Multipoint terminations to a circuit - [`2ccaae4`](https://github.com/netbox-community/netbox/commit/2ccaae42a818851ed4274da644fe202ea236492e) Undo change to .gitignore - [`08bc5df`](https://github.com/netbox-community/netbox/commit/08bc5df9e30fcd065a6517ce46e5d3ac6cbbdb52) Fixed provider filter by site name - [`5b78bb0`](https://github.com/netbox-community/netbox/commit/5b78bb0738eae70d9859519ca8c41f015550b7d5) Fixed Multipoint filtering - [`510bf5c`](https://github.com/netbox-community/netbox/commit/510bf5ca67700068b6b6b1c03ba6efa1b21d6968) Fixed PEP8 issues with multipoint circuits - [`bbc4283`](https://github.com/netbox-community/netbox/commit/bbc428359d3defbd37ca00c527a0b8de542f12b7) Merge remote-tracking branch 'upstream/develop' into multipoint_circuits - [`3d59b40`](https://github.com/netbox-community/netbox/commit/3d59b406aeca16948ba59c07f49e84a93aa77667) Re-added terminations to forms.py - [`047ccaa`](https://github.com/netbox-community/netbox/commit/047ccaa14ea656dc0b12facb47fefd4c4713a644) Fixed pep8 error - [`6510c6e`](https://github.com/netbox-community/netbox/commit/6510c6e70e861f70c66f162a57a5433e68378896) Fixed issues with terminations in dcim and APIs - [`ffe374c`](https://github.com/netbox-community/netbox/commit/ffe374c54ca2db9b54c66f5f18d6832a7299a324) Modified gitignore to not include gunicorn ### 📊 Changes **29 files changed** (+552 additions, -182 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+3 -0) 📝 `netbox/circuits/admin.py` (+15 -5) 📝 `netbox/circuits/api/serializers.py` (+1 -4) 📝 `netbox/circuits/api/views.py` (+2 -2) 📝 `netbox/circuits/filters.py` (+3 -16) 📝 `netbox/circuits/forms.py` (+114 -6) ➕ `netbox/circuits/migrations/0006_auto_20160908_0213.py` (+42 -0) ➕ `netbox/circuits/migrations/0007_auto_20160908_0220.py` (+43 -0) ➕ `netbox/circuits/migrations/0008_remove_termination_comments.py` (+19 -0) ➕ `netbox/circuits/migrations/0009_termination_comments.py` (+20 -0) 📝 `netbox/circuits/models.py` (+37 -12) 📝 `netbox/circuits/tables.py` (+3 -6) 📝 `netbox/circuits/urls.py` (+5 -0) 📝 `netbox/circuits/views.py` (+69 -4) 📝 `netbox/dcim/api/serializers.py` (+1 -1) 📝 `netbox/dcim/api/views.py` (+1 -1) 📝 `netbox/dcim/forms.py` (+3 -3) 📝 `netbox/dcim/models.py` (+2 -2) 📝 `netbox/dcim/tests/test_apis.py` (+0 -1) 📝 `netbox/dcim/views.py` (+4 -4) _...and 9 more files_ </details> ### 📄 Description From #49. This allows end users to create multipoint circuits. There is a new class in the circuits model called Terminations. It takes most of the items from circuits. Since a circuit could have different port speeds/commit rates on different terminations, that was removed from the circuits class and added to Terminations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:19:30 +01:00
adam closed this issue 2025-12-29 22:19:31 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12077
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?