starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #204] [CLOSED] Support VLAN in Import Prefixes, Add VLAN column to Prefixes page #12003

New Issue
Closed
opened 2025-12-29 22:19:05 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:19:05 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/204
Author: @Gelob
Created: 7/6/2016
Status: ❌ Closed

Base: develop ← Head: vlanimport

📝 Commits (2)

  • 4ea7076 Support VLAN in Import Prefixes, Add VLAN column to Prefixes page
  • 4eee663 Fix issues failing CI

📊 Changes

5 files changed (+37 additions, -19 deletions)

View changed files

📝 netbox/ipam/forms.py (+12 -3)
📝 netbox/ipam/tables.py (+2 -1)
📝 netbox/templates/ipam/prefix_bulk_edit.html (+1 -0)
📝 netbox/templates/ipam/prefix_import.html (+6 -1)
📝 netbox/utilities/forms.py (+16 -14)

📄 Description

Addresses #42

This commit adds support for including the VLAN Name when importing prefixes. This also adds the VLAN Display Name to the prefixes view. I've changed the size on the site and role choice fields in in order to save some space because most people will have more VLANs than sites or roles.

The import will throw an error if you have a VLAN with the same VID and name. Its not super descriptive but if anyone has suggestions on how to pull the VLAN Name out of the exception information please let me know.

Screenshot of above described error and other changes to the page's examples
screen shot 2016-07-06 at 2 12 46 am

Screenshot of new view on Prefixes page
screen shot 2016-07-06 at 2 13 35 am

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/204 **Author:** [@Gelob](https://github.com/Gelob) **Created:** 7/6/2016 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `vlanimport` --- ### 📝 Commits (2) - [`4ea7076`](https://github.com/netbox-community/netbox/commit/4ea70763e1c715759a305a4162380e1bbd34b7e7) Support VLAN in Import Prefixes, Add VLAN column to Prefixes page - [`4eee663`](https://github.com/netbox-community/netbox/commit/4eee663895f93dffb1ca5665f88cfd71efaf82de) Fix issues failing CI ### 📊 Changes **5 files changed** (+37 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/forms.py` (+12 -3) 📝 `netbox/ipam/tables.py` (+2 -1) 📝 `netbox/templates/ipam/prefix_bulk_edit.html` (+1 -0) 📝 `netbox/templates/ipam/prefix_import.html` (+6 -1) 📝 `netbox/utilities/forms.py` (+16 -14) </details> ### 📄 Description Addresses #42 This commit adds support for including the VLAN Name when importing prefixes. This also adds the VLAN Display Name to the prefixes view. I've changed the size on the site and role choice fields in in order to save some space because most people will have more VLANs than sites or roles. The import will throw an error if you have a VLAN with the same VID and name. Its not super descriptive but if anyone has suggestions on how to pull the VLAN Name out of the exception information please let me know. Screenshot of above described error and other changes to the page's examples <img width="1361" alt="screen shot 2016-07-06 at 2 12 46 am" src="https://cloud.githubusercontent.com/assets/422752/16610188/4c08ce42-431f-11e6-9ce5-c52d21311841.png"> Screenshot of new view on Prefixes page <img width="888" alt="screen shot 2016-07-06 at 2 13 35 am" src="https://cloud.githubusercontent.com/assets/422752/16610197/5e27dd66-431f-11e6-9a37-91e4a9499ed4.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:19:05 +01:00
adam closed this issue 2025-12-29 22:19:06 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#12003
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?