starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #170] [MERGED] Add MAC address to interface #11994

New Issue
Closed
opened 2025-12-29 22:19:02 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:19:02 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/170
Author: @peelman
Created: 7/1/2016
Status: ✅ Merged
Merged: 7/6/2016
Merged by: @jeremystretch

Base: develop ← Head: add-mac-address-to-interface

📝 Commits (9)

  • 5034b83 Add MAC address field to interfaces
  • 6fb530b Relocate Add Interface button to match the style used in the rest of the view
  • 0ce92cb Add fixtures for mac addresses. add mac addresses to api tests
  • 9da4c28 Tests pass now
  • a6d41c9 Remove external macaddress package dependency
  • 9f75d5b Fix PEP8 compliance...
  • 578013f Fix PEP8 compliance...(again)
  • dc847ce Fix connected interface template rendering...
  • 7a2f6ea Regenerate migration

📊 Changes

11 files changed (+127 additions, -13 deletions)

View changed files

📝 netbox/dcim/api/serializers.py (+2 -2)
➕ netbox/dcim/fields.py (+44 -0)
📝 netbox/dcim/fixtures/dcim.json (+4 -1)
➕ netbox/dcim/formfields.py (+26 -0)
📝 netbox/dcim/forms.py (+2 -2)
➕ netbox/dcim/migrations/0005_auto_20160706_1722.py (+26 -0)
📝 netbox/dcim/models.py (+2 -0)
📝 netbox/dcim/tests/test_apis.py (+2 -0)
📝 netbox/dcim/views.py (+2 -0)
📝 netbox/templates/dcim/device.html (+8 -3)
📝 netbox/templates/dcim/inc/_interface.html (+9 -5)

📄 Description

This is my first foray into a Django app...so feedback and/or modifications are welcome...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/170 **Author:** [@peelman](https://github.com/peelman) **Created:** 7/1/2016 **Status:** ✅ Merged **Merged:** 7/6/2016 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `add-mac-address-to-interface` --- ### 📝 Commits (9) - [`5034b83`](https://github.com/netbox-community/netbox/commit/5034b836ea5131020cdafefe6b640f23233ae945) Add MAC address field to interfaces - [`6fb530b`](https://github.com/netbox-community/netbox/commit/6fb530b75dce673b70a8345aac43756becf50fd3) Relocate Add Interface button to match the style used in the rest of the view - [`0ce92cb`](https://github.com/netbox-community/netbox/commit/0ce92cb2eec062b9f010f36a6d6badc23376bc6e) Add fixtures for mac addresses. add mac addresses to api tests - [`9da4c28`](https://github.com/netbox-community/netbox/commit/9da4c28cd50cdb07cd5e2c97a56a259231d2f642) Tests pass now - [`a6d41c9`](https://github.com/netbox-community/netbox/commit/a6d41c95b85cff9780406c53f8d525ccfaabe6aa) Remove external macaddress package dependency - [`9f75d5b`](https://github.com/netbox-community/netbox/commit/9f75d5bd237faf70f7906c356deea91294b1b0d9) Fix PEP8 compliance... - [`578013f`](https://github.com/netbox-community/netbox/commit/578013fdd2e2319a93aa69fc9d2f13eee8566b63) Fix PEP8 compliance...(again) - [`dc847ce`](https://github.com/netbox-community/netbox/commit/dc847ce4d6f26d200717b0578a6a8921ad1e1d67) Fix connected interface template rendering... - [`7a2f6ea`](https://github.com/netbox-community/netbox/commit/7a2f6eaf34e549eebbbffd7decc15ae6abf7e8d9) Regenerate migration ### 📊 Changes **11 files changed** (+127 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/api/serializers.py` (+2 -2) ➕ `netbox/dcim/fields.py` (+44 -0) 📝 `netbox/dcim/fixtures/dcim.json` (+4 -1) ➕ `netbox/dcim/formfields.py` (+26 -0) 📝 `netbox/dcim/forms.py` (+2 -2) ➕ `netbox/dcim/migrations/0005_auto_20160706_1722.py` (+26 -0) 📝 `netbox/dcim/models.py` (+2 -0) 📝 `netbox/dcim/tests/test_apis.py` (+2 -0) 📝 `netbox/dcim/views.py` (+2 -0) 📝 `netbox/templates/dcim/device.html` (+8 -3) 📝 `netbox/templates/dcim/inc/_interface.html` (+9 -5) </details> ### 📄 Description This is my first foray into a Django app...so feedback and/or modifications are welcome... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:19:02 +01:00
adam closed this issue 2025-12-29 22:19:02 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11994
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?