starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #100] [MERGED] Replace pydot by graphviz #11986

New Issue
Closed
opened 2025-12-29 21:53:48 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:53:48 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/100
Author: @pitkley
Created: 6/29/2016
Status: ✅ Merged
Merged: 6/29/2016
Merged by: @jeremystretch

Base: develop ← Head: replace-pydot

📝 Commits (1)

  • 522a0c2 Replace pydot by graphviz

📊 Changes

2 files changed (+15 additions, -20 deletions)

View changed files

📝 netbox/extras/api/views.py (+14 -19)
📝 requirements.txt (+1 -1)

📄 Description

This is in an effort to support Python 3 in the future: pydot is not compatible with Python 3, while graphviz is.

From some limited testing I have done, the resulting PNGs were absolutely identical. Additionally, this should make #71 obsolete, since graphviz automatically includes empty double quotes (label="") if the supplied string was empty.

As for Python 3 compatibility: AFAICT ncclient is currently the only other dependency that is incompatible with Python 3. There is an updated version 0.5.0 available on PyPi-test which supports Python 3, but the full release to PyPi has not happened yet (there is at least one issue asking for the release).

As soon as ncclient==0.5.0 is released, one should be able to make NetBox compatible with Python 3 in addition to Python 2.7.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/100 **Author:** [@pitkley](https://github.com/pitkley) **Created:** 6/29/2016 **Status:** ✅ Merged **Merged:** 6/29/2016 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `replace-pydot` --- ### 📝 Commits (1) - [`522a0c2`](https://github.com/netbox-community/netbox/commit/522a0c20e7a0c13a7a675ad67be1751613bd307d) Replace pydot by graphviz ### 📊 Changes **2 files changed** (+15 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/api/views.py` (+14 -19) 📝 `requirements.txt` (+1 -1) </details> ### 📄 Description This is in an effort to support Python 3 in the future: pydot is not compatible with Python 3, while graphviz is. From some limited testing I have done, the resulting PNGs were absolutely identical. Additionally, this should make #71 obsolete, since graphviz automatically includes empty double quotes (`label=""`) if the supplied string was empty. --- As for Python 3 compatibility: AFAICT `ncclient` is currently the only other dependency that is incompatible with Python 3. There is an updated version [0.5.0 available on PyPi-test](https://testpypi.python.org/pypi/ncclient/0.5.0) which supports Python 3, but the full release to PyPi has not happened yet (there is at least [one issue](https://github.com/ncclient/ncclient/issues/138) asking for the release). As soon as `ncclient==0.5.0` is released, one should be able to make NetBox compatible with Python 3 in addition to Python 2.7. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 21:53:48 +01:00
adam closed this issue 2025-12-29 21:53:49 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11986
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?