starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Harmonize displaying json data from the netbox configuration #11925

New Issue
Open
opened 2025-12-29 21:51:33 +01:00 by adam · 6 comments
adam commented 2025-12-29 21:51:33 +01:00
Owner
Copy Link

Originally created by @jonasnieberle on GitHub (Dec 15, 2025).

Originally assigned to: @jnovinger on GitHub.

NetBox version

v4.4.8

Feature type

New functionality

Proposed functionality

Harmonize the displaying of Json data in the configuration history view:

At the moment only the "Default preferences" are rendered correct as JSON form:

Image

I think it make sense to render the Validation rules for objects as JSON as well:

Image

I think is just adding the "|json" statement, here:

Image

Use case

Better and easier readability of the json data.

Database changes

External dependencies

Originally created by @jonasnieberle on GitHub (Dec 15, 2025). Originally assigned to: @jnovinger on GitHub. ### NetBox version v4.4.8 ### Feature type New functionality ### Proposed functionality Harmonize the displaying of Json data in the configuration history view: At the moment only the "Default preferences" are rendered correct as JSON form: <img width="357" height="166" alt="Image" src="https://github.com/user-attachments/assets/f69cb96d-acdd-438d-8b4b-2e55394df340" /> I think it make sense to render the Validation rules for objects as JSON as well: <img width="479" height="167" alt="Image" src="https://github.com/user-attachments/assets/0bbb9980-e7ed-45d8-a0b7-341da24b5b75" /> I think is just adding the "|json" statement, here: <img width="1019" height="757" alt="Image" src="https://github.com/user-attachments/assets/3385aaa3-5af2-4bbd-afdb-5e7ce50fcc38" /> ### Use case Better and easier readability of the json data. ### Database changes - ### External dependencies -
adam added the status: acceptedtype: featurenetboxcomplexity: low labels 2025-12-29 21:51:33 +01:00
adam commented 2025-12-29 21:51:35 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (Dec 15, 2025):

@jonasnieberle, can you re-confirm as I can not reproduce this in my local.

Image

These filters were removed explicitly in #17219 and #18369. My understanding is that these should be working this way already, due to the new specialized [ConfigJSONEncoder](https://github.com/netbox-community/netbox/pull/17247) introduced in the fix for # #17219.

@jnovinger commented on GitHub (Dec 15, 2025): @jonasnieberle, can you re-confirm as I can not reproduce this in my local. <img width="1033" height="764" alt="Image" src="https://github.com/user-attachments/assets/0c41e9db-281d-49f0-8ea3-9cd93ed6cd25" /> These filters were removed explicitly in #17219 and #18369. My understanding is that these should be working this way already, due to the new specialized `[ConfigJSONEncoder](https://github.com/netbox-community/netbox/pull/17247)` introduced in the fix for # #17219.
adam commented 2025-12-29 21:51:35 +01:00
Author
Owner
Copy Link

@jonasnieberle commented on GitHub (Dec 16, 2025):

@jnovinger yes that's right, but it only works at system --> config.

Navigate to Configuration History --> click on the ID of a config-revisions and then you see it.

Image

Thats from the demo environment: https://demo.netbox.dev/core/config-revisions/2/

Image
@jonasnieberle commented on GitHub (Dec 16, 2025): @jnovinger yes that's right, but it only works at system --> config. Navigate to Configuration History --> click on the ID of a config-revisions and then you see it. <img width="495" height="319" alt="Image" src="https://github.com/user-attachments/assets/e4742101-9d61-42f9-9eef-2811cf915ba2" /> Thats from the demo environment: https://demo.netbox.dev/core/config-revisions/2/ <img width="1475" height="223" alt="Image" src="https://github.com/user-attachments/assets/85a7f18a-7b11-4d2f-aebf-82b7b19b0d6c" />
adam commented 2025-12-29 21:51:35 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (Dec 17, 2025):

@jnovinger yes that's right, but it only works at system --> config.

Ah, excellent point. Apologies for the confusion. Is this something you'd like to tackle, @jonasnieberle?

@jnovinger commented on GitHub (Dec 17, 2025): > [@jnovinger](https://github.com/jnovinger) yes that's right, but it only works at system --> config. Ah, excellent point. Apologies for the confusion. Is this something you'd like to tackle, @jonasnieberle?
adam commented 2025-12-29 21:51:36 +01:00
Author
Owner
Copy Link

@jonasnieberle commented on GitHub (Dec 19, 2025):

@jnovinger Im not very familar with software development and alle processes with github / branching ... etc.
I think it's just adding the "|json" statement to the code which I provide in the first message. For someone who know all the processes just 5min work :)

@jonasnieberle commented on GitHub (Dec 19, 2025): @jnovinger Im not very familar with software development and alle processes with github / branching ... etc. I think it's just adding the "|json" statement to the code which I provide in the first message. For someone who know all the processes just 5min work :)
adam commented 2025-12-29 21:51:36 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (Dec 20, 2025):

@jnovinger Im not very familar with software development and alle processes with github / branching ... etc. I think it's just adding the "|json" statement to the code which I provide in the first message. For someone who know all the processes just 5min work :)

Understood, appreciate the report!

@jnovinger commented on GitHub (Dec 20, 2025): > [@jnovinger](https://github.com/jnovinger) Im not very familar with software development and alle processes with github / branching ... etc. I think it's just adding the "|json" statement to the code which I provide in the first message. For someone who know all the processes just 5min work :) Understood, appreciate the report!
adam commented 2025-12-29 21:51:36 +01:00
Author
Owner
Copy Link

@jonasnieberle commented on GitHub (Dec 28, 2025):

@jnovinger I have some time, so I will try it. Please assign the FR to me :)

@jonasnieberle commented on GitHub (Dec 28, 2025): @jnovinger I have some time, so I will try it. Please assign the FR to me :)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label complexity: low netbox status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11925
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?