starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Add missing SQL indexes #11912

New Issue
Closed
opened 2025-12-29 21:51:27 +01:00 by adam · 1 comment
adam commented 2025-12-29 21:51:27 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Dec 9, 2025).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Add indexes for generic foreign keys on the following models:

  • circuits.CircuitTermination (termination_type, termination_id)
  • dcim.MACAddress (assigned_object_type, assigned_object_id)
  • ipam.Prefix (scope_type, scope_id)
  • virtualization.Cluster (scope_type, scope_id)
  • wireless.WirelessLAN (scope_type, scope_id)

Additionally, ensure that all models have indexes for fields which are used for default ordering.

Justification

Adding these indexes will improve response times for common queries where a large number of records exist.

Originally created by @jeremystretch on GitHub (Dec 9, 2025). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Add indexes for generic foreign keys on the following models: - circuits.CircuitTermination (`termination_type`, `termination_id`) - dcim.MACAddress (`assigned_object_type`, `assigned_object_id`) - ipam.Prefix (`scope_type`, `scope_id`) - virtualization.Cluster (`scope_type`, `scope_id`) - wireless.WirelessLAN (`scope_type`, `scope_id`) ~Additionally, ensure that all models have indexes for fields which are used for default ordering.~ ### Justification Adding these indexes will improve response times for common queries where a large number of records exist.
adam added the status: acceptedtype: housekeepingnetbox labels 2025-12-29 21:51:27 +01:00
adam closed this issue 2025-12-29 21:51:27 +01:00
adam commented 2025-12-29 21:51:27 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Dec 15, 2025):

It also seems that there should be an index for ('tree_id', 'lft') on all models which employ MPTT, but it's not clear why these have not been created automatically. Upgrading to django-mptt v0.18 introduces a migration for the InventoryItem and InventoryItemTemplate models only; I suspect this is because these are the only models which inherit from MPTTModel directly.

@jeremystretch commented on GitHub (Dec 15, 2025): It also seems that there should be an index for `('tree_id', 'lft')` on all models which employ MPTT, but it's not clear why these have not been created automatically. Upgrading to django-mptt v0.18 introduces a migration for the InventoryItem and InventoryItemTemplate models only; I suspect this is because these are the only models which inherit from MPTTModel directly.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label netbox status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11912
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?