starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

allow rack type "mounting depth" to be either inches or millimeters #11902

New Issue
Closed
opened 2025-12-29 21:51:21 +01:00 by adam · 2 comments
adam commented 2025-12-29 21:51:21 +01:00
Owner
Copy Link

Originally created by @rconkor on GitHub (Dec 7, 2025).

NetBox version

v.4.4.7

Feature type

Change to existing functionality

Proposed functionality

adjust "mounting depth" for rack types to work the same way as "width, height, depth" allowing users to input a value, then select a unit of measurement (inches or millimeters)

Use case

currently, rack type dimensions (height, width, depth) allow for the selection of either millimeters or inches for the measuring unit.

However, when inputting the "mounting depth" the value must be millimeters.

We'd like to see the rack type mounting depth be more consistent and follow the value inputs for the other measurements (height, width, depth, weight)

EDIT: Very rough stab at the changes

from .choices import RackDimensionUnitChoices 

class RackBase(WeightMixin, PrimaryModel):
    # ...

    mounting_depth = models.DecimalField( 
        verbose_name=_('mounting depth'),
        max_digits=7,
        decimal_places=2,
        blank=True,
        null=True,
        help_text=_(
            'Maximum depth of a mounted device. '
            'For four-post racks, this is the distance between the front and rear rails.'
        ),
    )

    mounting_depth_unit = models.CharField(
        verbose_name=_('mounting depth unit'),
        max_length=50,
        choices=RackDimensionUnitChoices,
        blank=True,
        null=True,
    )

Database changes

would need to extend the field to also store the measuring unit, to do the conversion.

External dependencies

none.

Originally created by @rconkor on GitHub (Dec 7, 2025). ### NetBox version v.4.4.7 ### Feature type Change to existing functionality ### Proposed functionality adjust "mounting depth" for rack types to work the same way as "width, height, depth" allowing users to input a value, then select a unit of measurement (inches or millimeters) ### Use case currently, rack type dimensions (height, width, depth) allow for the selection of either millimeters or inches for the measuring unit. However, when inputting the "mounting depth" the value must be millimeters. We'd like to see the rack type mounting depth be more consistent and follow the value inputs for the other measurements (height, width, depth, weight) EDIT: Very rough stab at the changes ``` from .choices import RackDimensionUnitChoices class RackBase(WeightMixin, PrimaryModel): # ... mounting_depth = models.DecimalField( verbose_name=_('mounting depth'), max_digits=7, decimal_places=2, blank=True, null=True, help_text=_( 'Maximum depth of a mounted device. ' 'For four-post racks, this is the distance between the front and rear rails.' ), ) mounting_depth_unit = models.CharField( verbose_name=_('mounting depth unit'), max_length=50, choices=RackDimensionUnitChoices, blank=True, null=True, ) ``` ### Database changes would need to extend the field to also store the measuring unit, to do the conversion. ### External dependencies none.
adam added the type: featurenetbox labels 2025-12-29 21:51:21 +01:00
adam closed this issue 2025-12-29 21:51:22 +01:00
adam commented 2025-12-29 21:51:22 +01:00
Author
Owner
Copy Link

@arthanson commented on GitHub (Dec 11, 2025):

Like the previous issue #20941 you can use millimeters to specify the mounting depth.

@arthanson commented on GitHub (Dec 11, 2025): Like the previous issue #20941 you can use millimeters to specify the mounting depth.
adam commented 2025-12-29 21:51:22 +01:00
Author
Owner
Copy Link

@rconkor commented on GitHub (Dec 11, 2025):

@arthanson again, I do not believe you are evaluating the spirit of consistency. NetBox allows for specifying units of measurement on the same page as rack depth.

That's like saying you can specify the rack weight in kilograms, so why allow to specify grams, pounds, or ounces?
Or set the height in millimeters so why allow inches?

I'm asking for NetBox to have more consistency. Literally the boxes above "mounting depth" all allow you to specify a unit of measurement. It doesn't make sense for mounting depth to be hard coded to millimeters.

@rconkor commented on GitHub (Dec 11, 2025): @arthanson again, I do not believe you are evaluating the spirit of consistency. NetBox allows for specifying units of measurement on the same page as rack depth. That's like saying you can specify the rack weight in kilograms, so why allow to specify grams, pounds, or ounces? Or set the height in millimeters so why allow inches? I'm asking for NetBox to have more consistency. Literally the boxes above "mounting depth" all allow you to specify a unit of measurement. It doesn't make sense for mounting depth to be hard coded to millimeters.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label netbox type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11902
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?