starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

IP Address Filtering on a Device excludes FHRP Grps #11833

New Issue
Closed
opened 2025-12-29 21:50:26 +01:00 by adam · 4 comments
adam commented 2025-12-29 21:50:26 +01:00
Owner
Copy Link

Originally created by @mkarel on GitHub (Nov 14, 2025).

NetBox Edition

NetBox Community

NetBox Version

v4.4.5

Python Version

3.10

Steps to Reproduce

To reproduce, create a FHRP Group I used the protocol of Other, Grp id 1, Name is the DNS name of the vip, set an IP address. Assign the FHRP group to a devices Interface(s). Once that is done do the following:

  1. Go to IPAM
  2. Click IP Addresses
  3. Click Filter
  4. in the Device / VM section chose the device you assigned
  5. Click Search

Expected Behavior

I would expect to see the IP address of the VIP (FHRP Group below) to be returned as an IP for that device or vm.

FHRP Group
Image

Observed Behavior

IP addresses are returned but just those that are assigned directly to an interface for a device, however the VIP that is assigned to an FHRP Grp and that is assigned to interfaces is not.

No VIP returned

Image
Originally created by @mkarel on GitHub (Nov 14, 2025). ### NetBox Edition NetBox Community ### NetBox Version v4.4.5 ### Python Version 3.10 ### Steps to Reproduce To reproduce, create a FHRP Group I used the protocol of Other, Grp id 1, Name is the DNS name of the vip, set an IP address. Assign the FHRP group to a devices Interface(s). Once that is done do the following: 1. Go to **IPAM** 2. Click **IP Addresses** 3. Click **Filter** 4. in the Device / VM section chose the device you assigned 5. Click **Search** ### Expected Behavior I would expect to see the IP address of the VIP (FHRP Group below) to be returned as an IP for that device or vm. FHRP Group <img width="1689" height="775" alt="Image" src="https://github.com/user-attachments/assets/a10ffee9-e2db-4ee9-ab30-ebc1ed844992" /> ### Observed Behavior IP addresses are returned but just those that are assigned directly to an interface for a device, however the VIP that is assigned to an FHRP Grp and that is assigned to interfaces is not. No VIP returned <img width="1678" height="368" alt="Image" src="https://github.com/user-attachments/assets/2412c164-365d-4ad5-9b8e-97c6da55860e" />
adam added the type: bugnetbox labels 2025-12-29 21:50:26 +01:00
adam closed this issue 2025-12-29 21:50:26 +01:00
adam commented 2025-12-29 21:50:27 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (Nov 17, 2025):

@mkarel, I believe this is intentional. You expected behavior contradicts the decision made when fixing #9116.

Alternatively, you can use the existing fhrpgroup_id filter to find IPs assigned to FHRP groups.

@jnovinger commented on GitHub (Nov 17, 2025): @mkarel, I believe this is intentional. You expected behavior contradicts the decision made when fixing #9116. Alternatively, you can use the existing `fhrpgroup_id` filter to find IPs assigned to FHRP groups.
adam commented 2025-12-29 21:50:27 +01:00
Author
Owner
Copy Link

@mkarel commented on GitHub (Nov 17, 2025):

@jnovinger, Thanks for the feedback, I will look at the fhrgroup_id filter. I guess what I don't understand is why when you filter on a device you would not want to see all IP's associated with that device.

@mkarel commented on GitHub (Nov 17, 2025): @jnovinger, Thanks for the feedback, I will look at the fhrgroup_id filter. I guess what I don't understand is why when you filter on a device you would not want to see all IP's associated with that device.
adam commented 2025-12-29 21:50:27 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (Nov 17, 2025):

@jnovinger, Thanks for the feedback, I will look at the fhrgroup_id filter. I guess what I don't understand is why when you filter on a device you would not want to see all IP's associated with that device.

I did notice that while fhrpgroup_id is present as a filter for the IP Address list view, it's not actually included in the filter form tab that's rendered for the page. We could probably stand to fix that.

As for why, that decision was before my time, so I'm unsure. If I find out, I'll let update this issue.

@jnovinger commented on GitHub (Nov 17, 2025): > [@jnovinger](https://github.com/jnovinger), Thanks for the feedback, I will look at the fhrgroup_id filter. I guess what I don't understand is why when you filter on a device you would not want to see all IP's associated with that device. I did notice that while `fhrpgroup_id` is present as a filter for the IP Address list view, it's not actually included in the filter form tab that's rendered for the page. We could probably stand to fix that. As for why, that decision was before my time, so I'm unsure. If I find out, I'll let update this issue.
adam commented 2025-12-29 21:50:28 +01:00
Author
Owner
Copy Link

@mkarel commented on GitHub (Nov 26, 2025):

@jnovinger Would you like to reopen this request or should I resubmit?

@mkarel commented on GitHub (Nov 26, 2025): @jnovinger Would you like to reopen this request or should I resubmit?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label netbox type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11833
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?