starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

JournalEntry Comments model is not set to allow empty (blank) comments #11818

New Issue
Closed
opened 2025-12-29 21:50:16 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:50:16 +01:00
Owner
Copy Link

Originally created by @arthanson on GitHub (Nov 7, 2025).

Originally assigned to: @arthanson on GitHub.

NetBox Edition

NetBox Community

NetBox Version

v4.4.5

Python Version

3.10

Steps to Reproduce

  1. Go to an object like a Site and click on the Journal tab
  2. Leave all the fields default (so Comments is blank) and click Save

Expected Behavior

The journal entry is saved, but the model actually isn't set correctly to allow it. This can cause issues with branching (see: #356.

Observed Behavior

If you look at other comment fields, for example netbox/models/__init__.py.PrimaryModel you will see that blank=True is set:

    comments = models.TextField(
        verbose_name=_('comments'),
        blank=True
    )

this corresponds to the utility/forms/fields/py.CommentField which sets required=False. But on JournalEntry it is defined:

    comments = models.TextField(
        verbose_name=_('comments'),
    )

The mis-match causes issues with Branching.

Originally created by @arthanson on GitHub (Nov 7, 2025). Originally assigned to: @arthanson on GitHub. ### NetBox Edition NetBox Community ### NetBox Version v4.4.5 ### Python Version 3.10 ### Steps to Reproduce 1. Go to an object like a Site and click on the Journal tab 2. Leave all the fields default (so Comments is blank) and click Save ### Expected Behavior The journal entry is saved, but the model actually isn't set correctly to allow it. This can cause issues with branching (see: [#356](https://github.com/netboxlabs/netbox-branching/issues/356). ### Observed Behavior If you look at other comment fields, for example `netbox/models/__init__.py.PrimaryModel` you will see that `blank=True` is set: ``` comments = models.TextField( verbose_name=_('comments'), blank=True ) ``` this corresponds to the `utility/forms/fields/py.CommentField` which sets `required=False`. But on JournalEntry it is defined: ``` comments = models.TextField( verbose_name=_('comments'), ) ``` The mis-match causes issues with Branching.
adam added the type: bugstatus: acceptednetboxseverity: low labels 2025-12-29 21:50:16 +01:00
adam closed this issue 2025-12-29 21:50:17 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label netbox severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11818
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?