starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Duplicate Responses in filterqueries #11813

New Issue
Closed
opened 2025-12-29 21:50:11 +01:00 by adam · 3 comments
adam commented 2025-12-29 21:50:11 +01:00
Owner
Copy Link

Originally created by @MrFoxTrot on GitHub (Nov 6, 2025).

Originally assigned to: @pheus on GitHub.

NetBox Edition

NetBox Community

NetBox Version

v4.4.5

Python Version

3.12

Steps to Reproduce

  1. Create Circuits ->Provider
  2. Create 2+ Circuits -> Provider Accounts assigned at Circuits ->Provider from first step
  3. Go to Circuits ->Provider and filter by created provider name

Expected Behavior

Query returns 1 object

Observed Behavior

Query returns 2+ objects with same id

Image
Originally created by @MrFoxTrot on GitHub (Nov 6, 2025). Originally assigned to: @pheus on GitHub. ### NetBox Edition NetBox Community ### NetBox Version v4.4.5 ### Python Version 3.12 ### Steps to Reproduce 1. Create Circuits ->Provider 2. Create 2+ Circuits -> Provider Accounts assigned at Circuits ->Provider from first step 3. Go to Circuits ->Provider and filter by created provider name ### Expected Behavior Query returns 1 object ### Observed Behavior Query returns 2+ objects with same id <img width="547" height="509" alt="Image" src="https://github.com/user-attachments/assets/7e65aa69-421b-4247-ac7f-bf0a12743bfd" />
adam added the type: bugstatus: acceptednetboxseverity: low labels 2025-12-29 21:50:11 +01:00
adam closed this issue 2025-12-29 21:50:11 +01:00
adam commented 2025-12-29 21:50:12 +01:00
Author
Owner
Copy Link

@bctiemann commented on GitHub (Nov 6, 2025):

I'd be interested to know whether this behavior occurs in any similar search results, i.e. anything with a "count" column in this kind of relationship. I'm going to open this as "needs owner", but @MrFoxTrot if you are able could you please do a quick check for other similar areas where this might be occurring?

@bctiemann commented on GitHub (Nov 6, 2025): I'd be interested to know whether this behavior occurs in any similar search results, i.e. anything with a "count" column in this kind of relationship. I'm going to open this as "needs owner", but @MrFoxTrot if you are able could you please do a quick check for other similar areas where this might be occurring?
adam commented 2025-12-29 21:50:13 +01:00
Author
Owner
Copy Link

@pheus commented on GitHub (Nov 6, 2025):

Thanks for the report! I dug into this and it doesn’t look like a common issue. The root cause is that ProviderFilterSet.search() is querying fields on the related ProviderAccount model in addition to the provider’s own name, description, and comments:

730d73042d/netbox/circuits/filtersets.py (L92-L93)

In NetBox, search() methods shouldn’t traverse related models.

I recommend removing the ProviderAccount lookups so the search is limited to the provider fields. If that sounds good, I’m happy to open a PR to address it.

@pheus commented on GitHub (Nov 6, 2025): Thanks for the report! I dug into this and it doesn’t look like a common issue. The root cause is that `ProviderFilterSet.search()` is querying fields on the related `ProviderAccount` model in addition to the provider’s own `name`, `description`, and `comments`: https://github.com/netbox-community/netbox/blob/730d73042d5ee34b31f16e2c978cb65718eb794e/netbox/circuits/filtersets.py#L92-L93 In NetBox, `search()` methods shouldn’t traverse related models. I recommend removing the `ProviderAccount` lookups so the search is limited to the provider fields. If that sounds good, I’m happy to open a PR to address it.
adam commented 2025-12-29 21:50:13 +01:00
Author
Owner
Copy Link

@bctiemann commented on GitHub (Nov 6, 2025):

@pheus That sounds right to me. Thanks!

@bctiemann commented on GitHub (Nov 6, 2025): @pheus That sounds right to me. Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label netbox severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11813
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?