starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Add contacts field to ip addresses table view #11783

New Issue
Closed
opened 2025-12-29 21:49:49 +01:00 by adam · 5 comments
adam commented 2025-12-29 21:49:49 +01:00
Owner
Copy Link

Originally created by @stalker-nn on GitHub (Oct 27, 2025).

Originally assigned to: @stalker-nn on GitHub.

NetBox version

v.4.4.4

Feature type

Change to existing functionality

Proposed functionality

I would like to suggest adding the Contacts field to the IP address table view settings. Currently, this field is unavailable for selection in the table configuration.

Use case

When viewing or exporting a list of IP addresses, it would be nice to see contact persons.

Database changes

No response

External dependencies

No response

Originally created by @stalker-nn on GitHub (Oct 27, 2025). Originally assigned to: @stalker-nn on GitHub. ### NetBox version v.4.4.4 ### Feature type Change to existing functionality ### Proposed functionality I would like to suggest adding the Contacts field to the IP address table view settings. Currently, this field is unavailable for selection in the table configuration. ### Use case When viewing or exporting a list of IP addresses, it would be nice to see contact persons. ### Database changes _No response_ ### External dependencies _No response_
adam added the status: acceptedtype: featurenetboxcomplexity: low labels 2025-12-29 21:49:49 +01:00
adam closed this issue 2025-12-29 21:49:50 +01:00
adam commented 2025-12-29 21:49:50 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (Oct 28, 2025):

I'm going to accept this, to maintain consistency with the other 15 models that already implement it, and assign it to you, @stalker-nn. In the future, please wait until a feature request is accepted and assigned to you before making a PR. We don't review PRs for unaccepted feature requests to avoid wasting both contributor and maintainer time on work that may not align with the project's direction or scope.

I'd also like for us to audit which models inherit from ContactsMixin and ensure they all get this same treatment. Is that something you can also commit to doing in your PR, @stalker-nn?

@jnovinger commented on GitHub (Oct 28, 2025): I'm going to accept this, to maintain consistency with the other 15 models that already implement it, and assign it to you, @stalker-nn. In the future, please wait until a feature request is accepted and assigned to you before making a PR. We don't review PRs for unaccepted feature requests to avoid wasting both contributor and maintainer time on work that may not align with the project's direction or scope. I'd also like for us to audit which models inherit from `ContactsMixin` and ensure they all get this same treatment. Is that something you can also commit to doing in your PR, @stalker-nn?
adam commented 2025-12-29 21:49:51 +01:00
Author
Owner
Copy Link

@stalker-nn commented on GitHub (Oct 28, 2025):

Thanks for accepting my request, @jnovinger

I checked the models that inherit from ContactsColumnMixin. They all contain this treatment, but the VirtualCircuit model is missing the 'contacts' attribute in the 'fields' tuple. It looks like this mixin automatically adds this attribute to 'fields'.

@stalker-nn commented on GitHub (Oct 28, 2025): Thanks for accepting my request, @jnovinger I checked the models that inherit from `ContactsColumnMixin`. They all contain this treatment, but the VirtualCircuit model is missing the 'contacts' attribute in the 'fields' tuple. It looks like this mixin automatically adds this attribute to 'fields'.
adam commented 2025-12-29 21:49:51 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (Oct 28, 2025):

Thanks, @stalker-nn. It looks like Jeremy has already merged your PR, so I will file a follow-up FR for this. FWIW, these are the models/tables I was thinking of:

┌───────────────────────────────────────┬────────────────────────────────────────────┐
│ Model Class Path                      │ Table Class Path                           │
├───────────────────────────────────────┼────────────────────────────────────────────┤
│ netbox.ipam.models.asns.ASN           │ netbox.ipam.tables.asn.ASNTable            │
│ netbox.ipam.models.ip.Aggregate       │ netbox.ipam.tables.ip.AggregateTable       │
│ netbox.ipam.models.ip.Prefix          │ netbox.ipam.tables.ip.PrefixTable          │
│ netbox.ipam.models.ip.IPRange         │ netbox.ipam.tables.ip.IPRangeTable         │
│ netbox.ipam.models.ip.IPAddress       │ netbox.ipam.tables.ip.IPAddressTable       │
│ netbox.vpn.models.tunnels.TunnelGroup │ netbox.vpn.tables.tunnels.TunnelGroupTable │
│ netbox.vpn.models.tunnels.Tunnel      │ netbox.vpn.tables.tunnels.TunnelTable      │
│ netbox.vpn.models.l2vpn.L2VPN         │ netbox.vpn.tables.l2vpn.L2VPNTable         │
└───────────────────────────────────────┴────────────────────────────────────────────┘
@jnovinger commented on GitHub (Oct 28, 2025): Thanks, @stalker-nn. It looks like Jeremy has already merged your PR, so I will file a follow-up FR for this. FWIW, these are the models/tables I was thinking of: ``` ┌───────────────────────────────────────┬────────────────────────────────────────────┐ │ Model Class Path │ Table Class Path │ ├───────────────────────────────────────┼────────────────────────────────────────────┤ │ netbox.ipam.models.asns.ASN │ netbox.ipam.tables.asn.ASNTable │ │ netbox.ipam.models.ip.Aggregate │ netbox.ipam.tables.ip.AggregateTable │ │ netbox.ipam.models.ip.Prefix │ netbox.ipam.tables.ip.PrefixTable │ │ netbox.ipam.models.ip.IPRange │ netbox.ipam.tables.ip.IPRangeTable │ │ netbox.ipam.models.ip.IPAddress │ netbox.ipam.tables.ip.IPAddressTable │ │ netbox.vpn.models.tunnels.TunnelGroup │ netbox.vpn.tables.tunnels.TunnelGroupTable │ │ netbox.vpn.models.tunnels.Tunnel │ netbox.vpn.tables.tunnels.TunnelTable │ │ netbox.vpn.models.l2vpn.L2VPN │ netbox.vpn.tables.l2vpn.L2VPNTable │ └───────────────────────────────────────┴────────────────────────────────────────────┘ ```
adam commented 2025-12-29 21:49:51 +01:00
Author
Owner
Copy Link

@stalker-nn commented on GitHub (Oct 28, 2025):

@jnovinger, thanks for the clarification. I can add a contacts field to these models if needed.

@stalker-nn commented on GitHub (Oct 28, 2025): @jnovinger, thanks for the clarification. I can add a `contacts` field to these models if needed.
adam commented 2025-12-29 21:49:51 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (Oct 28, 2025):

@jnovinger, thanks for the clarification. I can add a contacts field to these models if needed.

Thanks, @stalker-nn. It looks like someone else has already picked this up. We appreciate your offer and look forward to more contributions from you in the future.

@jnovinger commented on GitHub (Oct 28, 2025): > [@jnovinger](https://github.com/jnovinger), thanks for the clarification. I can add a `contacts` field to these models if needed. Thanks, @stalker-nn. It looks like someone else has already picked this up. We appreciate your offer and look forward to more contributions from you in the future.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label complexity: low netbox status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11783
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?