starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Remove Circuit Swap Terminations #11778

New Issue
Closed
opened 2025-12-29 21:49:45 +01:00 by adam · 1 comment
adam commented 2025-12-29 21:49:45 +01:00
Owner
Copy Link

Originally created by @arthanson on GitHub (Oct 24, 2025).

Originally assigned to: @arthanson on GitHub.

Proposed Changes

Within Circuits detail view there is a "Swap" button on the terminations that will switch the places of the terminations.

Justification

This is a niche utility function that can be replicated by simply editing the first termination to unset the termination side, then editing the second termination and setting its termination side. Several points on this:

  • It doesn't add any new functionality, just a convenience function
  • It is a one-off there is no consistency with cables or such (they don't have a swap function).
  • There is no corresponding REST API that does the same thing.
  • It adds complexity to the code.
  • The way it does the swap makes it difficult for branching and requires maintaining / debugging unique code. See #282 in branching
Originally created by @arthanson on GitHub (Oct 24, 2025). Originally assigned to: @arthanson on GitHub. ### Proposed Changes Within Circuits detail view there is a "Swap" button on the terminations that will switch the places of the terminations. ### Justification This is a niche utility function that can be replicated by simply editing the first termination to unset the termination side, then editing the second termination and setting its termination side. Several points on this: * It doesn't add any new functionality, just a convenience function * It is a one-off there is no consistency with cables or such (they don't have a swap function). * There is no corresponding REST API that does the same thing. * It adds complexity to the code. * The way it does the swap makes it difficult for branching and requires maintaining / debugging unique code. See [#282](https://github.com/netboxlabs/netbox-branching/issues/282) in branching
adam added the type: deprecationnetbox labels 2025-12-29 21:49:45 +01:00
adam closed this issue 2025-12-29 21:49:45 +01:00
adam commented 2025-12-29 21:49:46 +01:00
Author
Owner
Copy Link

@arthanson commented on GitHub (Oct 28, 2025):

merged in #20684. Closing

@arthanson commented on GitHub (Oct 28, 2025): merged in [#20684](https://github.com/netbox-community/netbox/pull/20684). Closing
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label netbox type: deprecation
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11778
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?