starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Introduce BaseModel to hold universal overrides for Django's models.Model #11747

New Issue
Closed
opened 2025-12-29 21:49:24 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:49:24 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Oct 17, 2025).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

  1. Introduce a new abstract model named BaseModel.
  2. Move the default manager definition to BaseModel.
  3. Move the clean() method from NetBoxModel to BaseModel.
  4. Update NetBoxModel & ChangeLoggedModel to inherit from BaseModel instead of models.Model.
  5. Update OrganizationalModel to inherit from NetBoxModel.

Justification

This approach does a better job of organizing stock functionality, and provides a convenient hook for (mostly) global model overrides. It will also allow for a slightly cleaner implementation of #20304.

Originally created by @jeremystretch on GitHub (Oct 17, 2025). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes 1. Introduce a new abstract model named BaseModel. 2. Move the default manager definition to BaseModel. 3. Move the `clean()` method from NetBoxModel to BaseModel. 4. Update NetBoxModel & ChangeLoggedModel to inherit from BaseModel instead of `models.Model`. 5. Update OrganizationalModel to inherit from NetBoxModel. ### Justification This approach does a better job of organizing stock functionality, and provides a convenient hook for (mostly) global model overrides. It will also allow for a slightly cleaner implementation of #20304.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 21:49:24 +01:00
adam closed this issue 2025-12-29 21:49:24 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11747
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?