starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Init storage at BaseScript level instead of within findstorage #11727

New Issue
Closed
opened 2025-12-29 21:49:11 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:49:11 +01:00
Owner
Copy Link

Originally created by @bctiemann on GitHub (Oct 14, 2025).

Originally assigned to: @bctiemann on GitHub.

NetBox Edition

NetBox Community

NetBox Version

v4.4.2

Python Version

3.10

Steps to Reproduce

In the BaseStorage class, the findstorage function inits an instance of storage for every call of the function (i.e. for every script). In the case of storage backends like S3, this can add significant and linearly increasing overhead time for every script file on the page.

Expected Behavior

Constant (low) page load time on /extras/scripts/

Observed Behavior

Significant (and linearly increasing with number of script files) page load time, i.e. ~7s+ per script file

Originally created by @bctiemann on GitHub (Oct 14, 2025). Originally assigned to: @bctiemann on GitHub. ### NetBox Edition NetBox Community ### NetBox Version v4.4.2 ### Python Version 3.10 ### Steps to Reproduce In the `BaseStorage` class, the `findstorage` function inits an instance of `storage` for every call of the function (i.e. for every script). In the case of storage backends like S3, this can add significant and linearly increasing overhead time for every script file on the page. ### Expected Behavior Constant (low) page load time on `/extras/scripts/` ### Observed Behavior Significant (and linearly increasing with number of script files) page load time, i.e. ~7s+ per script file
adam added the type: bugstatus: acceptedseverity: low labels 2025-12-29 21:49:11 +01:00
adam closed this issue 2025-12-29 21:49:11 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11727
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?