PUT on Existing Devices Returns Errors #1170

New Issue

adam · 2025-12-29T16:29:41+01:00

adam commented

2025-12-29 16:29:41 +01:00

Originally created by @zachmoody on GitHub (Aug 11, 2017).

Issue type: Bug

Python version: 2.7.6
NetBox version: develop

Updating device with PUT failed RU validation. Seems it was introduced in 1f9806a480. I think the error is the result of a ValidationError raised after checking for available RU. Here's the error:

{"non_field_errors":["U<RU> is already occupied or does not have sufficient space to accommodate a(n) <MODEL>."]}

This should test for the behavior.

--- a/netbox/dcim/tests/test_api.py
+++ b/netbox/dcim/tests/test_api.py
@@ -1267,8 +1267,10 @@ class DeviceTest(HttpStatusMixin, APITestCase):
         self.devicerole2 = DeviceRole.objects.create(
             name='Test Device Role 2', slug='test-device-role-2', color='00ff00'
         )
+        self.site1_r1 = Rack.objects.create(name='Test Rack S1R1', site=self.site1)
         self.device1 = Device.objects.create(
-            device_type=self.devicetype1, device_role=self.devicerole1, name='Test Device 1', site=self.site1
+            device_type=self.devicetype1, device_role=self.devicerole1, name='Test Device 1', site=self.site1,
+            rack=self.site1_r1, position=42, face=1
         )
         self.device2 = Device.objects.create(
             device_type=self.devicetype1, device_role=self.devicerole1, name='Test Device 2', site=self.site1
@@ -1331,6 +1333,24 @@ class DeviceTest(HttpStatusMixin, APITestCase):
         self.assertEqual(device1.name, data['name'])
         self.assertEqual(device1.site_id, data['site'])

+    def test_update_device_field(self):
+        '''Update a single field on a device'''
+        data = {
+            'name': 'Test Device X',
+            'device_type': self.devicetype1.pk,
+            'device_role': self.devicerole1.pk,
+            'site': self.site1.pk,
+            'position': 42,
+            'rack': self.site1_r1.pk,
+            'face': 1,
+        }
+        url = reverse('dcim-api:device-detail', kwargs={'pk': self.device1.pk})
+        response = self.client.put(url, data, **self.header)
+        self.assertHttpStatus(response, status.HTTP_200_OK)
+        self.assertEqual(Device.objects.count(), 3)
+        device1 = Device.objects.get(pk=response.data['id'])
+        self.assertEqual(device1.name, 'Test Device X')
+
     def test_delete_device(self):

         url = reverse('dcim-api:device-detail', kwargs={'pk': self.device1.pk})

Originally created by @zachmoody on GitHub (Aug 11, 2017).  ### Issue type: Bug  **Python version:** 2.7.6 **NetBox version:** develop  Updating device with `PUT` failed RU validation. Seems it was introduced in 1f9806a480589764c6dca3e78e39b8d26648e3e5. I think the error is the result of a ValidationError raised after checking for available RU. Here's the error: ``` {"non_field_errors":["U<RU> is already occupied or does not have sufficient space to accommodate a(n) <MODEL>."]} ``` This should test for the behavior. ```diff --- a/netbox/dcim/tests/test_api.py +++ b/netbox/dcim/tests/test_api.py @@ -1267,8 +1267,10 @@ class DeviceTest(HttpStatusMixin, APITestCase): self.devicerole2 = DeviceRole.objects.create( name='Test Device Role 2', slug='test-device-role-2', color='00ff00' ) + self.site1_r1 = Rack.objects.create(name='Test Rack S1R1', site=self.site1) self.device1 = Device.objects.create( - device_type=self.devicetype1, device_role=self.devicerole1, name='Test Device 1', site=self.site1 + device_type=self.devicetype1, device_role=self.devicerole1, name='Test Device 1', site=self.site1, + rack=self.site1_r1, position=42, face=1 ) self.device2 = Device.objects.create( device_type=self.devicetype1, device_role=self.devicerole1, name='Test Device 2', site=self.site1 @@ -1331,6 +1333,24 @@ class DeviceTest(HttpStatusMixin, APITestCase): self.assertEqual(device1.name, data['name']) self.assertEqual(device1.site_id, data['site']) + def test_update_device_field(self): + '''Update a single field on a device''' + data = { + 'name': 'Test Device X', + 'device_type': self.devicetype1.pk, + 'device_role': self.devicerole1.pk, + 'site': self.site1.pk, + 'position': 42, + 'rack': self.site1_r1.pk, + 'face': 1, + } + url = reverse('dcim-api:device-detail', kwargs={'pk': self.device1.pk}) + response = self.client.put(url, data, **self.header) + self.assertHttpStatus(response, status.HTTP_200_OK) + self.assertEqual(Device.objects.count(), 3) + device1 = Device.objects.get(pk=response.data['id']) + self.assertEqual(device1.name, 'Test Device X') + def test_delete_device(self): url = reverse('dcim-api:device-detail', kwargs={'pk': self.device1.pk}) ```

adam added the type: bug label 2025-12-29 16:29:41 +01:00

adam closed this issue

2025-12-29 16:29:41 +01:00

adam commented

2025-12-29 16:29:42 +01:00

@zachmoody commented on GitHub (Aug 15, 2017):

Dug a bit more into this. Seems that self.pk is None which is causing the logic in clean() to treat it like a new device. 🤔

@zachmoody commented on GitHub (Aug 15, 2017): Dug a bit more into this. Seems that `self.pk` is None which is causing the logic in clean() to treat it like a new device. 🤔

Sign in to join this conversation.

Branches Tags

main

21050-device-oob-ip-may-become-orphaned

21102-fix-graphiql-explorer

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#1170