starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Disable "Virtual Interface" types from displaying in "LLDP Neighbors" tab of device #1169

New Issue
Closed
opened 2025-12-29 16:29:41 +01:00 by adam · 2 comments
adam commented 2025-12-29 16:29:41 +01:00
Owner
Copy Link

Originally created by @bdlamprecht on GitHub (Aug 11, 2017).

Issue type:

Bug

NetBox version:
2.1.2

With the recent integration of NAPALM, LLDP information is displayed on the "LLDP Neighbors" tab of a device. Currently all interfaces are displayed on the that tab (including "Virtual" interfaces that will never have a neighbor.

This request is to exclude those all "virtual" and "lag" interfaces from being displayed on that tab.

Originally created by @bdlamprecht on GitHub (Aug 11, 2017). ### Issue type: Bug **NetBox version:** 2.1.2 With the recent integration of NAPALM, LLDP information is displayed on the "LLDP Neighbors" tab of a device. Currently *all* interfaces are displayed on the that tab (including "Virtual" interfaces that will _never_ have a neighbor. This request is to exclude those all "virtual" and "lag" interfaces from being displayed on that tab.
adam added the type: bug label 2025-12-29 16:29:41 +01:00
adam closed this issue 2025-12-29 16:29:41 +01:00
adam commented 2025-12-29 16:29:41 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Aug 14, 2017):

Calling this a bug since the current behavior doesn't really make sense.

@jeremystretch commented on GitHub (Aug 14, 2017): Calling this a bug since the current behavior doesn't really make sense.
adam commented 2025-12-29 16:29:42 +01:00
Author
Owner
Copy Link

@huzichunjohn commented on GitHub (Aug 15, 2017):

--- a/netbox/dcim/views.py
+++ b/netbox/dcim/views.py
@@ -32,6 +32,7 @@ from .models import (
     Manufacturer, InventoryItem, Platform, PowerOutlet, PowerOutletTemplate, PowerPort, PowerPortTemplate, Rack,
     RackGroup, RackReservation, RackRole, Region, Site,
 )
+from .constants import *
 
 
 EXPANSION_PATTERN = '\[(\d+-\d+)\]'
@@ -937,8 +938,10 @@ class DeviceLLDPNeighborsView(PermissionRequiredMixin, View):
         interfaces = Interface.objects.order_naturally(
             device.device_type.interface_ordering
         ).filter(
-            device=device
-        ).select_related(
+            device=device,
+       ).exclude(
+           form_factor__in=VIRTUAL_IFACE_TYPES
+       ).select_related(
             'connected_as_a', 'connected_as_b'
         )
@huzichunjohn commented on GitHub (Aug 15, 2017): ```diff --- a/netbox/dcim/views.py +++ b/netbox/dcim/views.py @@ -32,6 +32,7 @@ from .models import ( Manufacturer, InventoryItem, Platform, PowerOutlet, PowerOutletTemplate, PowerPort, PowerPortTemplate, Rack, RackGroup, RackReservation, RackRole, Region, Site, ) +from .constants import * EXPANSION_PATTERN = '\[(\d+-\d+)\]' @@ -937,8 +938,10 @@ class DeviceLLDPNeighborsView(PermissionRequiredMixin, View): interfaces = Interface.objects.order_naturally( device.device_type.interface_ordering ).filter( - device=device - ).select_related( + device=device, + ).exclude( + form_factor__in=VIRTUAL_IFACE_TYPES + ).select_related( 'connected_as_a', 'connected_as_b' ) ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#1169
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?