starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Change to the ordering of 'add_button' parameters broke fix #19990 #11619

New Issue
Closed
opened 2025-12-29 21:47:42 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:47:42 +01:00
Owner
Copy Link

Originally created by @9er-tom on GitHub (Sep 16, 2025).

NetBox Edition

NetBox Community

NetBox Version

v4.4.0

Python Version

3.12

Steps to Reproduce

  1. Navigate to object list view which has missing prerequisites
  2. Click on '+ Add' button
  3. Observe how netbox tries to navigate to '/<object_list>/None' path

Expected Behavior

Button should navigate to <object_list>/add?return_url=<object_list>

Observed Behavior

Changing the order of 'action' and 'return_url' breakes #19990 due to the django template in missing_prerequisites.html interpreting 'request.path' as the action instead of the return_url. This leads to the missing prerequisite Add button navigating to /object/objects/None

Originally posted by @9er-tom in d433456

Originally created by @9er-tom on GitHub (Sep 16, 2025). ### NetBox Edition NetBox Community ### NetBox Version v4.4.0 ### Python Version 3.12 ### Steps to Reproduce 1. Navigate to object list view which has missing prerequisites 2. Click on '+ Add' button 3. Observe how netbox tries to navigate to '<url>/<object_list>/None' path ### Expected Behavior Button should navigate to <object_list>/add?return_url=<object_list> ### Observed Behavior > Changing the order of 'action' and 'return_url' breakes #19990 due to the django template in missing_prerequisites.html interpreting 'request.path' as the action instead of the return_url. This leads to the missing prerequisite Add button navigating to <url>/object/objects/None _Originally posted by @9er-tom in [d433456](https://github.com/netbox-community/netbox/commit/d433456e2f1249425e59f88694f52a0d94cff38d#r165867452)_
adam added the type: bugstatus: duplicate labels 2025-12-29 21:47:42 +01:00
adam closed this issue 2025-12-29 21:47:42 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: duplicate type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11619
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?