starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

DynamicModelChoiceField does not propagate required error in UI #11518

New Issue
Closed
opened 2025-12-29 21:46:19 +01:00 by adam · 1 comment
adam commented 2025-12-29 21:46:19 +01:00
Owner
Copy Link

Originally created by @arthanson on GitHub (Aug 22, 2025).

Deployment Type

Self-hosted

NetBox Version

v4.3.6

Python Version

3.12

Steps to Reproduce

The easiest way to show this is to modify NetBox code as there currently isn't a case where we use DynamicModelChoiceField with required.

  1. Go into netbox.dcim.forms.model_forms.SiteForm for the region = DynamicModelChoiceField for field change required=False to required=True
  2. Add a new site, set the name, slug and status. Note that Region correctly shows that it is required - don't fill anything in for Region.
  3. Click Create

Expected Behavior

The for should error and the Region field should be highlighted in red and "This field is required" should be shown below it.

Observed Behavior

The form doesn't submit, but there is no indication of why it didn't submit. There is no highlight or indication that the Region field is the problem.

Originally created by @arthanson on GitHub (Aug 22, 2025). ### Deployment Type Self-hosted ### NetBox Version v4.3.6 ### Python Version 3.12 ### Steps to Reproduce The easiest way to show this is to modify NetBox code as there currently isn't a case where we use DynamicModelChoiceField with required. 1. Go into netbox.dcim.forms.model_forms.SiteForm for the `region = DynamicModelChoiceField` for field change `required=False` to `required=True` 2. Add a new site, set the name, slug and status. Note that Region correctly shows that it is required - don't fill anything in for Region. 3. Click Create ### Expected Behavior The for should error and the Region field should be highlighted in red and "This field is required" should be shown below it. ### Observed Behavior The form doesn't submit, but there is no indication of why it didn't submit. There is no highlight or indication that the Region field is the problem.
adam added the type: bugstatus: duplicate labels 2025-12-29 21:46:19 +01:00
adam closed this issue 2025-12-29 21:46:19 +01:00
adam commented 2025-12-29 21:46:20 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (Aug 22, 2025):

@arthanson , pretty this is a duplicate of #18916.

@jnovinger commented on GitHub (Aug 22, 2025): @arthanson , pretty this is a duplicate of #18916.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: duplicate type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11518
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?